Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor process_payment and wc-stripe-is-deferred-intent flag #3868

Open
ricardo opened this issue Feb 11, 2025 · 0 comments
Open

Refactor process_payment and wc-stripe-is-deferred-intent flag #3868

ricardo opened this issue Feb 11, 2025 · 0 comments
Labels
type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@ricardo
Copy link
Member

ricardo commented Feb 11, 2025

The goal of this issue is to track this "To be removed" check:

// Flag for using a deferred intent. To be removed.
if ( ! empty( $_POST['wc-stripe-is-deferred-intent'] ) ) {
return $this->process_payment_with_deferred_intent( $order_id );
}

The $_POST['wc-stripe-is-deferred-intent'] parameter was introduced in #2935 and meant to be temporary.

Removing this flag also involves refactoring process_payment, and as a result from this issue, we expect a unified process_payment that works for both deferred and non-deferred intent payment methods and phases out any code paths that still consider old iterations like the no-longer supported unified Payment Element.

Additional context

#3805 (comment)

@ricardo ricardo added the type: technical debt This issue/PR represents/solves the technical debt of the project. label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Development

No branches or pull requests

1 participant