iPad: Fix split view not working after the initial launch #2 (#15989)

Author: staskus

WooCommerce/Classes/ViewRelated/MainTabBarController.swift

@@ -190,14 +190,14 @@ final class MainTabBarController: UITabBarController {
 
         delegate = self
 
-        fixTabBarTraitCollectionOnIpadForiOS18()
-
         // POS tab is hidden by default.
         updateTabViewControllers(isPOSTabVisible: false)
         observeSiteIDForViewControllers()
         observeProductImageUploadStatusUpdates()
 
         startListeningToHubMenuTabBadgeUpdates()
+
+        fixTabBarTraitCollectionOnIpadForiOS18()
     }
 
     override func viewWillAppear(_ animated: Bool) {
@@ -294,7 +294,7 @@ final class MainTabBarController: UITabBarController {
     private func fixTabBarTraitCollectionOnIpadForiOS18() {
         if #available(iOS 18.0, *), UIDevice.current.userInterfaceIdiom == .pad {
             traitOverrides.horizontalSizeClass = .compact
-            if let rootHorizontalSizeClass = view.window?.traitCollection.horizontalSizeClass {
+            if let rootHorizontalSizeClass = AppDelegate.shared.window?.traitCollection.horizontalSizeClass {
                 tabBar.traitOverrides.horizontalSizeClass = rootHorizontalSizeClass
                 if let viewControllers {
                     for vc in viewControllers {