Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] Improve Checkout view adaptability to large font sizes #15153

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

staskus
Copy link
Contributor

@staskus staskus commented Feb 14, 2025

Closes: #15123

Before tackling #15152, I'm updating the view to better support larger accessibility sizes

Description

The idea was to play with layoutPriority. However, it only works up to the point, we need to give permission for views to shrink, either by making resizable images (.resizable) or resizable texts (.minimumScaleFactor). Also, TotalsView texts are large enough for non-scroll view, so I decided to limit the size with dynamicTypeSizerange.

Changes:

  • Updated POSFontStyleto support dynamicTypeSizerange, replaced existing UIContentSizeusage
  • Updated payment state views to either hide images or shrink images when accessibility increased
  • Updated priorities and limited text growth within `TotalsView``

Steps to reproduce

I suggest testing with:

  • Common size device - iPad Air / Pro
  • Small size device - iPad Mini

Test these checkout states with different accessibility sizes:

  • Waiting for reader
  • Waiting to tap/swipe card
  • Order preparation errors
  • Payment success

Testing information

Tested with iPad Air M2 and iPad Mini A17

Screenshots

iPad.mini.A17.Pro.Accessibility.mp4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@staskus staskus added type: bug A confirmed bug. category: accessibility Related to accessibility. feature: POS labels Feb 14, 2025
@staskus staskus added this to the 21.8 milestone Feb 14, 2025
@staskus staskus requested a review from iamgabrielma February 14, 2025 17:14
@staskus staskus changed the title Fix/15123 woo pos cash payment button accessibility [Woo POS] Improve Checkout view accessibility Feb 14, 2025
@staskus staskus changed the title [Woo POS] Improve Checkout view accessibility [Woo POS] Improve Checkout view adaptability to large font sizes Feb 14, 2025
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr15153-800dfb6
Version21.7
Bundle IDcom.automattic.alpha.woocommerce
Commit800dfb6
App Center BuildWooCommerce - Prototype Builds #12974
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: accessibility Related to accessibility. feature: POS type: bug A confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Woo POS] Cash Payment button doesn't fit for large accessibility sizes
2 participants