Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] MVP analytics: improve POSCollectOrderPaymentAnalyticsTracking conformance #15149

Open
iamgabrielma opened this issue Feb 14, 2025 · 1 comment
Labels
category: tracks Related to analytics, including Tracks Events. feature: POS type: task An internally driven task.

Comments

@iamgabrielma
Copy link
Contributor

iamgabrielma commented Feb 14, 2025

Ref: #15138 (comment)

Theoretically, we could have
POSCollectOrderPaymentAnalyticsTracking: CollectOrderPaymentAnalyticsTracking that has func trackCustomerInteractionStarted(), and POSCollectOrderPaymentAnalytics would implement POSCollectOrderPaymentAnalyticsTracking. This way non-POS parts of the code, such as various preflight controllers wouldn't have knowledge of trackCustomerInteractionStarted. POS aggregate model would expect POSCollectOrderPaymentAnalyticsTracking.

@iamgabrielma iamgabrielma added category: tracks Related to analytics, including Tracks Events. feature: POS type: task An internally driven task. labels Feb 14, 2025
@dangermattic
Copy link
Collaborator

Thanks for reporting! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tracks Related to analytics, including Tracks Events. feature: POS type: task An internally driven task.
Projects
None yet
Development

No branches or pull requests

2 participants