Application password login add analytic events (#21886)

* Adding analytic event

* Minor refactor

* Fixing test

* Adding event properties

* Detekt

* Fixing test

Author: adalpari

WordPress/src/main/java/org/wordpress/android/ui/accounts/login/ApplicationPasswordLoginHelper.kt

@@ -4,15 +4,22 @@ import android.util.Log
 import androidx.core.net.toUri
 import kotlinx.coroutines.CoroutineDispatcher
 import kotlinx.coroutines.withContext
+import org.wordpress.android.analytics.AnalyticsTracker
+import org.wordpress.android.analytics.AnalyticsTracker.Stat
 import org.wordpress.android.fluxc.persistence.SiteSqlUtils
 import org.wordpress.android.modules.BG_THREAD
+import org.wordpress.android.util.BuildConfigWrapper
 import javax.inject.Inject
 import javax.inject.Named
 
+private const val URL_TAG = "url"
+private const val SUCCESS_TAG = "success"
+
 class ApplicationPasswordLoginHelper @Inject constructor(
     @param:Named(BG_THREAD) private val bgDispatcher: CoroutineDispatcher,
     private val siteSqlUtils: SiteSqlUtils,
-    private val uriLoginWrapper: UriLoginWrapper
+    private val uriLoginWrapper: UriLoginWrapper,
+    private val buildConfigWrapper: BuildConfigWrapper,
 ) {
     private var processedAppPasswordData: String? = null
 
@@ -30,11 +37,13 @@ class ApplicationPasswordLoginHelper @Inject constructor(
             } else {
                 val site = siteSqlUtils.getSites().firstOrNull { it.url == uriLogin.siteUrl }
                 if (site != null) {
-                    site.apiRestUsername = uriLogin.user
-                    site.apiRestPassword = uriLogin.password
+                    site.apply {
+                        apiRestUsername = uriLogin.user
+                        apiRestPassword = uriLogin.password
+                    }
                     siteSqlUtils.insertOrUpdateSite(site)
-                    Log.d("WP_RS", "Saved application password credentials for: ${uriLogin.siteUrl}")
-                    processedAppPasswordData = url
+                    uriLogin.siteUrl?.let { trackSuccessful(it) }
+                    processedAppPasswordData = url // Save locally to avoid duplicated calls
                     true
                 } else {
                     Log.e("WP_RS", "Cannot save application password credentials for: ${uriLogin.siteUrl}")
@@ -44,6 +53,21 @@ class ApplicationPasswordLoginHelper @Inject constructor(
         }
     }
 
+    private fun trackSuccessful(siteUrl: String) {
+        val properties: MutableMap<String, String?> = HashMap()
+        properties[URL_TAG] = siteUrl
+        properties[SUCCESS_TAG] = "true"
+        AnalyticsTracker.track(
+            if (buildConfigWrapper.isJetpackApp) {
+                Stat.JP_ANDROID_APPLICATION_PASSWORD_LOGIN
+            } else {
+                Stat.WP_ANDROID_APPLICATION_PASSWORD_LOGIN
+            },
+            properties
+        )
+        Log.d("WP_RS", "Saved application password credentials for: $siteUrl")
+    }
+
     fun getSiteUrlFromUrl(url: String): String {
         return uriLoginWrapper.parseUriLogin(url).siteUrl.orEmpty()
     }

WordPress/src/test/java/org/wordpress/android/ui/accounts/login/ApplicationPasswordLoginHelperTest.kt

@@ -13,6 +13,7 @@ import org.mockito.kotlin.whenever
 import org.wordpress.android.BaseUnitTest
 import org.wordpress.android.fluxc.model.SiteModel
 import org.wordpress.android.fluxc.persistence.SiteSqlUtils
+import org.wordpress.android.util.BuildConfigWrapper
 import kotlin.test.assertEquals
 import kotlin.test.assertFalse
 import kotlin.test.assertTrue
@@ -29,12 +30,15 @@ class ApplicationPasswordLoginHelperTest : BaseUnitTest() {
      @Mock
      lateinit var uriLoginWrapper: ApplicationPasswordLoginHelper.UriLoginWrapper
 
+     @Mock
+     lateinit var buildConfigWrapper: BuildConfigWrapper
+
     private lateinit var helper: ApplicationPasswordLoginHelper
 
     @Before
     fun setUp() {
         MockitoAnnotations.openMocks(this)
-        helper = ApplicationPasswordLoginHelper(testDispatcher(), siteSqlUtils, uriLoginWrapper)
+        helper = ApplicationPasswordLoginHelper(testDispatcher(), siteSqlUtils, uriLoginWrapper, buildConfigWrapper)
         whenever(uriLoginWrapper.parseUriLogin(any()))
             .thenReturn(
                 ApplicationPasswordLoginHelper.UriLogin(TEST_URL, TEST_USER, TEST_PASSWORD)

libs/analytics/src/main/java/org/wordpress/android/analytics/AnalyticsTracker.java

@@ -1156,7 +1156,9 @@ public enum Stat {
         VOICE_TO_CONTENT_BUTTON_CLOSE_TAPPED,
         VOICE_TO_CONTENT_BUTTON_RECORDING_LIMIT_REACHED,
         BACKGROUND_REST_AUTODISCOVERY_SUCCESSFUL,
-        BACKGROUND_REST_AUTODISCOVERY_FAILED;
+        BACKGROUND_REST_AUTODISCOVERY_FAILED,
+        WP_ANDROID_APPLICATION_PASSWORD_LOGIN,
+        JP_ANDROID_APPLICATION_PASSWORD_LOGIN;
         /*
          * Please set the event name in the enum only if the new Stat's name in lower case does not match it.
          * In that case you also need to add the event in the `AnalyticsTrackerNosaraTest.specialNames` map.