Skip to content

Commit 5236003

Browse files
authored
Move more pods to SPM (#23395)
2 parents caee457 + 9ffd18c commit 5236003

File tree

5 files changed

+137
-200
lines changed

5 files changed

+137
-200
lines changed

Podfile

Lines changed: 0 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,6 @@ def aztec
2929
pod 'WordPress-Editor-iOS', '~> 1.19.11'
3030
end
3131

32-
def gravatar
33-
# pod 'Gravatar', path: '../Gravatar-SDK-iOS'
34-
# pod 'GravatarUI', path: '../Gravatar-SDK-iOS'
35-
# pod 'Gravatar', git: 'https://github.com/Automattic/Gravatar-SDK-iOS', commit: ''
36-
# pod 'GravatarUI', git: 'https://github.com/Automattic/Gravatar-SDK-iOS', commit: ''
37-
pod 'Gravatar', '2.0.0'
38-
pod 'GravatarUI', '2.0.0'
39-
end
40-
4132
abstract_target 'Apps' do
4233
project 'WordPress/WordPress.xcodeproj'
4334

@@ -55,20 +46,9 @@ abstract_target 'Apps' do
5546
pod 'AppCenter', app_center_version, configurations: app_center_configurations
5647
pod 'AppCenter/Distribute', app_center_version, configurations: app_center_configurations
5748

58-
pod 'FSInteractiveMap', git: 'https://github.com/wordpress-mobile/FSInteractiveMap.git', tag: '0.2.0'
59-
pod 'CropViewController', '2.5.3'
60-
6149
## Automattic libraries
6250
## ====================
6351
##
64-
gravatar
65-
66-
# Production
67-
68-
pod 'MediaEditor', '~> 1.2', '>= 1.2.2'
69-
# pod 'MediaEditor', git: 'https://github.com/wordpress-mobile/MediaEditor-iOS.git', commit: ''
70-
# pod 'MediaEditor', path: '../MediaEditor-iOS'
71-
7252
aztec
7353

7454
## WordPress App iOS
@@ -132,39 +112,6 @@ abstract_target 'Tools' do
132112
pod 'SwiftLint', swiftlint_version
133113
end
134114

135-
# Static Frameworks:
136-
# ============
137-
#
138-
# Make all pods that are not shared across multiple targets into static frameworks by overriding the static_framework? function to return true
139-
# Linking the shared frameworks statically would lead to duplicate symbols
140-
# A future version of CocoaPods may make this easier to do. See https://github.com/CocoaPods/CocoaPods/issues/7428
141-
shared_targets = %w[WordPressFlux]
142-
dyanmic_framework_pods = %w[WordPressFlux]
143-
# Statically linking Sentry results in a conflict with `NSDictionary.objectAtKeyPath`, but dynamically
144-
# linking it resolves this.
145-
dyanmic_framework_pods += %w[Sentry SentryPrivate]
146-
pre_install do |installer|
147-
static = []
148-
dynamic = []
149-
installer.pod_targets.each do |pod|
150-
use_dynamic_frameworks = false
151-
use_dynamic_frameworks = true if dyanmic_framework_pods.include? pod.name
152-
153-
# If this pod is a dependency of one of our shared targets, it must be linked dynamically
154-
use_dynamic_frameworks = true if pod.target_definitions.any? { |t| shared_targets.include? t.name }
155-
156-
if use_dynamic_frameworks
157-
dynamic << pod
158-
pod.instance_variable_set(:@build_type, Pod::BuildType.dynamic_framework)
159-
else
160-
static << pod
161-
pod.instance_variable_set(:@build_type, Pod::BuildType.static_framework)
162-
end
163-
end
164-
puts "Installing #{static.count} pods as static frameworks"
165-
puts "Installing #{dynamic.count} pods as dynamic frameworks"
166-
end
167-
168115
post_install do |installer|
169116
gutenberg_post_install(installer: installer)
170117

Podfile.lock

Lines changed: 1 addition & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,7 @@ PODS:
99
- AppCenter/Core
1010
- AppCenter/Distribute (5.0.4):
1111
- AppCenter/Core
12-
- CropViewController (2.5.3)
13-
- FSInteractiveMap (0.1.0)
14-
- Gravatar (2.0.0)
15-
- GravatarUI (2.0.0):
16-
- Gravatar (= 2.0.0)
1712
- Gutenberg (1.120.1)
18-
- MediaEditor (1.2.2):
19-
- CropViewController (~> 2.5.3)
2013
- SwiftLint (0.54.0)
2114
- WordPress-Aztec-iOS (1.19.11)
2215
- WordPress-Editor-iOS (1.19.11):
@@ -25,12 +18,7 @@ PODS:
2518
DEPENDENCIES:
2619
- AppCenter (~> 5.0)
2720
- AppCenter/Distribute (~> 5.0)
28-
- CropViewController (= 2.5.3)
29-
- FSInteractiveMap (from `https://github.com/wordpress-mobile/FSInteractiveMap.git`, tag `0.2.0`)
30-
- Gravatar (= 2.0.0)
31-
- GravatarUI (= 2.0.0)
3221
- Gutenberg (from `https://cdn.a8c-ci.services/gutenberg-mobile/Gutenberg-v1.120.1.podspec`)
33-
- MediaEditor (>= 1.2.2, ~> 1.2)
3422
- SwiftLint (= 0.54.0)
3523
- WordPress-Editor-iOS (~> 1.19.11)
3624

@@ -40,36 +28,19 @@ SPEC REPOS:
4028
- WordPress-Editor-iOS
4129
trunk:
4230
- AppCenter
43-
- CropViewController
44-
- Gravatar
45-
- GravatarUI
46-
- MediaEditor
4731
- SwiftLint
4832

4933
EXTERNAL SOURCES:
50-
FSInteractiveMap:
51-
:git: https://github.com/wordpress-mobile/FSInteractiveMap.git
52-
:tag: 0.2.0
5334
Gutenberg:
5435
:podspec: https://cdn.a8c-ci.services/gutenberg-mobile/Gutenberg-v1.120.1.podspec
5536

56-
CHECKOUT OPTIONS:
57-
FSInteractiveMap:
58-
:git: https://github.com/wordpress-mobile/FSInteractiveMap.git
59-
:tag: 0.2.0
60-
6137
SPEC CHECKSUMS:
6238
AppCenter: 85c92db0759d2792a65eb61d6842d2e86611a49a
63-
CropViewController: a5c143548a0fabcd6cc25f2d26e40460cfb8c78c
64-
FSInteractiveMap: a396f610f48b76cb540baa87139d056429abda86
65-
Gravatar: 54fc63ea6298e9afca7329007815be25868f1dfe
66-
GravatarUI: bb5e03cda2da61e54aa1c20d4dde32b7153fa8b4
6739
Gutenberg: 0699e7dd207afb591ccd5e81252a92e6e7781391
68-
MediaEditor: d08314cfcbfac74361071a306b4bc3a39b3356ae
6940
SwiftLint: c1de071d9d08c8aba837545f6254315bc900e211
7041
WordPress-Aztec-iOS: 3732c6d865a5c9f35788377bdeda8a80ea10d0a1
7142
WordPress-Editor-iOS: 453345420ced3d3ef20f0051b3df46ff10281e0c
7243

73-
PODFILE CHECKSUM: 3f613d671323ac233553cfced32e6931b915bdc8
44+
PODFILE CHECKSUM: 12f9ac933ee5c704604bf92375b97c4b6c04a8f3
7445

7546
COCOAPODS: 1.15.2

WordPress.xcworkspace/xcshareddata/swiftpm/Package.resolved

Lines changed: 36 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

WordPress/Classes/ViewRelated/Me/Views/Header/MeHeaderView.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
#import "MeHeaderView.h"
22
#import "Blog.h"
33
#import "WordPress-Swift.h"
4-
#import "Gravatar-Swift.h"
54

65
@import WordPressShared;
6+
@import Gravatar;
77

88
const CGFloat MeHeaderViewHeight = 154;
99
const CGFloat MeHeaderViewGravatarSize = 64.0;

0 commit comments

Comments
 (0)