-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook hangs viewing Doggo source #232
Comments
Which browser are you using? It works just fine for me in Firefox (browser is responsive). |
Safari doesn't have an issue with this either, but Chrome is weak. |
Anyway, I don't think putting each function component into its own module is reasonable. Maybe I'm planning to make the components customizable in a future version, which would have an impact on the source code display, though, so I don't think it's worth it to think about the module structure of doggo at this point. |
Sorry I intended to provide that in the original report. I was just testing it with Brave which is chromium based. |
I'll close this for now. Storybook renders the source code of the whole module where the component is defined. With the new build macros, you will only see the macro calls, which is even less helpful. We'll look into whether we can modify Storybook to allow overriding the default source view. This is tracked separately in #308. |
Describe the bug
When using storybook and viewing there source of a Doggo component the file is so large that the browser hangs mand becomes unresponsive processing the mark up.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Whilst this seems like the root cause may be a storybook issue, a single large file with all components is not ideal.
Please consider breaking out components into separate module files such as accordion.ex, button.ex etc
The text was updated successfully, but these errors were encountered: