Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending User link doesn't filter to pending users #75

Open
d2roth opened this issue Feb 4, 2019 · 0 comments
Open

Pending User link doesn't filter to pending users #75

d2roth opened this issue Feb 4, 2019 · 0 comments

Comments

@d2roth
Copy link

d2roth commented Feb 4, 2019

When receiving the email sent via approve_approval_email to the administrators, the admin_url just goes to the all users page and not to the pending users' filtered view.

I tracked the issue down to the URL that is being created. The URL generated is using the wrong url parameter. It uses new_user_approve_filter=pending instead of new_user_approve_filter-top=pending, notice the "-top".

Here is the line where the parameter is incorrect:
https://github.com/picklewagon/new-user-approve/blob/ea615a3634df638a6c53ad5461e39b0e102e09fd/new-user-approve.php#L427

If you want I can create a pull request with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant