Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Querying getRoleListOfUser(userName) for each application for the same user #2114

Open
kasunsiyambalapitiya opened this issue Mar 19, 2019 · 0 comments

Comments

@kasunsiyambalapitiya
Copy link

kasunsiyambalapitiya commented Mar 19, 2019

Description:
When loading the Service Provider page for the logged in user from Management console, the following method isUserAuthorized is executed for each application which in turn queries the UserStore with the following method getRoleListOfUser(username) of the relevant userstore for getting roles list of the logged in user in order to match with the applicationRoleName. Here the above call is redundant as it will always return the same role list of the logged in user for each application.

The above flow can be optimized such that userStoreManager.getRoleListOfUser(username); is called to get roles list of the logged in user first and then validate the above-obtained roles with each applicationRoleName

Suggested Labels:
Type/Improvement

Affected Product Version:
wso2is-5.7.0
OS, DB, other environment details and versions:
Any

Related Issues:
wso2/product-is#4678

ten2net pushed a commit to tongpi/carbon-identity-framework that referenced this issue Apr 1, 2019
ten2net pushed a commit to tongpi/carbon-identity-framework that referenced this issue Apr 1, 2019
mxm-tr added a commit to mxm-tr/carbon-identity-framework that referenced this issue Nov 22, 2022
mxm-tr added a commit to mxm-tr/carbon-identity-framework that referenced this issue Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant