Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

werkzeug.contrib.cache.RedisCache uses pickle #232

Open
mutantmonkey opened this issue Nov 26, 2016 · 2 comments
Open

werkzeug.contrib.cache.RedisCache uses pickle #232

mutantmonkey opened this issue Nov 26, 2016 · 2 comments
Labels
enhancement security

Comments

@mutantmonkey
Copy link
Member

Pickle is not a safe way to serialize objects. We should consider using JSON instead. This can be done by subclassing RedisCache and replacing dump_object and load_object.
@echarlie
Copy link
Member

@mutantmonkey can we close this? yes, pickle is unsafe, but I think we decided it was an acceptable risk

@mutantmonkey
Copy link
Member Author

Eh, I would prefer to leave it open, even though we're not going to have a fix ready in the short term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mutantmonkey @echarlie