Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout issue with version 11.0.2 #80

Closed
manuelosorio opened this issue Jun 18, 2021 · 7 comments
Closed

Layout issue with version 11.0.2 #80

manuelosorio opened this issue Jun 18, 2021 · 7 comments

Comments

@manuelosorio
Copy link

The change made to src/lib/ngx-masonry.directive.ts in commit 66534b4 ended up breaking the layout I had. I'm not completely sure to what that change actually does but below I'm providing links to a few screenshots to show the issue.

[email protected]
http://prnt.sc/15shks4
http://prnt.sc/15shkzv

[email protected]
http://prnt.sc/15sj99m
https://prnt.sc/15sgl9r
http://prnt.sc/15sh4t2

@manuelosorio manuelosorio changed the title Layout issues with version 11.0.2 Layout issue with version 11.0.2 Jun 18, 2021
@wynfred
Copy link
Owner

wynfred commented Jun 23, 2021

Hi, not sure how that change could cause the bug. Do you have images in that component?

@manuelosorio
Copy link
Author

I do not have images on the component. I honestly don't know how it would affect it either.

@manuelosorio
Copy link
Author

manuelosorio commented Jun 28, 2021

Component GIST: https://gist.github.com/manuelosorio/be2290111426a1aee4912dbfe890d679.
I looked furthered into the issue. It seams that this only happens when images are not the target for the masonry item.

Pull request: #81 seams to fixed the problem when I add [ready]='true'

  <ngx-masonry [options]="masonryOptions" [ordered]="true"  class="lists-container">
      <div ngxMasonryItem [ready]='true' class="masonry-item" *ngFor="let list of masonryLists">
          ...
      </div>
  </ngx-masonry>

@wynfred
Copy link
Owner

wynfred commented Sep 3, 2021

Hi, I'm not sure if it's the same issue but I think I fixed the one in #81. Please try the new release and see if it works and feel free to reopen if it doesn't. Thank you!

@wynfred wynfred closed this as completed Sep 3, 2021
@manuelosorio
Copy link
Author

I tried the new update. I'm still having the same issue where an empty space at the top of my ngx-masonry items.

@wynfred
Copy link
Owner

wynfred commented Sep 19, 2021

Then it could be a different issue. Could you try make a stackblitz repro?

@manuelosorio
Copy link
Author

@wynfred I made a stackblitz. I had to manually add the ngx-masonry repo as ngcc was not compiling it on stackblitz after install.

The component using ngx-masonry is fake-list.

https://stackblitz.com/edit/todo-demo

https://todo-demo.stackblitz.io/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants