Skip to content

Commit 1237353

Browse files
committed
Treat syntax error as non internal
1 parent 835ff2c commit 1237353

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

pkg/stream/stream_run.go

+2
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,7 @@ func Run(ctx context.Context, logger loglib.Logger, config *Config, instrumentat
211211
return err
212212
}
213213
defer pgBatchWriter.Close()
214+
logger.Info("starting postgres batch writer...")
214215

215216
processor = pgBatchWriter
216217

@@ -222,6 +223,7 @@ func Run(ctx context.Context, logger loglib.Logger, config *Config, instrumentat
222223
logger.Info("adding transformation layer to processor...")
223224
transformer, err := transformer.New(config.Processor.Transformer, processor, transformer.WithLogger(logger))
224225
if err != nil {
226+
logger.Error(err, "creating transformer layer")
225227
return err
226228
}
227229
processor = transformer

pkg/wal/processor/postgres/postgres_batch_writer.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -242,9 +242,11 @@ func (w *BatchWriter) execQueries(ctx context.Context, queries []*query) ([]*que
242242
func (w *BatchWriter) isInternalError(err error) bool {
243243
var errRelationDoesNotExist *pglib.ErrRelationDoesNotExist
244244
var errConstraintViolation *pglib.ErrConstraintViolation
245+
var errSyntaxError *pglib.ErrSyntaxError
245246
switch {
246247
case errors.As(err, &errRelationDoesNotExist),
247-
errors.As(err, &errConstraintViolation):
248+
errors.As(err, &errConstraintViolation),
249+
errors.As(err, &errSyntaxError):
248250
return false
249251
default:
250252
return true

0 commit comments

Comments
 (0)