Add support for bootstrapping the release package

To build release package, we need a pure-upstream buildenv (and incidently,
an older xcp-ng-release currently becomes uninstallable every time upstream
updates almalinux-release, breaking existing containers.

Signed-off-by: Yann Dirson <[email protected]>

Author: ydirson

src/xcp_ng_dev/build.sh

@@ -20,11 +20,13 @@ usage() {
 Usage: $SELF_NAME [--platform PF] <version>
 ... where <version> is a 'x.y' version such as 8.0.
 
---platform override the default platform for the build container.
+--platform   override the default platform for the build container.
+--bootstrap  generate a bootstrap image, needed to build xcp-ng-release.
 EOF
 }
 
 PLATFORM=
+BOOTSTRAP=0
 while [ $# -ge 1 ]; do
     case "$1" in
         --help|-h)
@@ -36,6 +38,9 @@ while [ $# -ge 1 ]; do
             PLATFORM="$2"
             shift
             ;;
+        --bootstrap)
+            BOOTSTRAP=1
+            ;;
         -*)
             die_usage "unknown flag '$1'"
             ;;
@@ -48,6 +53,12 @@ done
 
 [ -n "$1" ] || die_usage "version parameter missing"
 
+case "$1" in
+    8.*)
+        [ $BOOTSTRAP = 0 ] || die "--bootstrap is only supported for XCP-ng 9.0 and newer"
+        ;;
+esac
+
 RUNNER=""
 if [ -n "$XCPNG_OCI_RUNNER" ]; then
     RUNNER="$XCPNG_OCI_RUNNER"
@@ -110,10 +121,17 @@ fi
 CUSTOM_ARGS+=( "--build-arg" "CUSTOM_BUILDER_UID=${CUSTOM_UID}" )
 CUSTOM_ARGS+=( "--build-arg" "CUSTOM_BUILDER_GID=${CUSTOM_GID}" )
 
+if [ $BOOTSTRAP = 0 ]; then
+    TAG=${1}
+else
+    TAG=${1}-bootstrap
+    CUSTOM_ARGS+=( "--build-arg" "BOOTSTRAP=1" )
+fi
+
 "$RUNNER" build \
     --platform "$PLATFORM" \
     "${CUSTOM_ARGS[@]}" \
-    -t ghcr.io/xcp-ng/xcp-ng-build-env:${1} \
+    -t ghcr.io/xcp-ng/xcp-ng-build-env:${TAG} \
     --build-arg XCP_NG_BRANCH=${1} \
     --ulimit nofile=1024 \
     -f $DOCKERFILE .

src/xcp_ng_dev/cli.py

@@ -56,6 +56,8 @@ def add_common_args(parser):
                        'If both --enablerepo and --disablerepo are set, --disablerepo will be applied first')
     group.add_argument('--no-update', action='store_true',
                        help='do not run "yum update" on container start, use it as it was at build time')
+    group.add_argument('--bootstrap', action='store_true',
+                       help='use a bootstrap build-env, able to build xc-ng-release')
 
 def add_container_args(parser):
     group = parser.add_argument_group("container arguments")
@@ -228,8 +230,12 @@ def container(args):
             # no argument
             pass
 
+    tag = args.container_version
+    if args.bootstrap:
+        tag += "-bootstrap"
+
     # exec "docker run"
-    docker_args += [f"{CONTAINER_PREFIX}:{args.container_version}",
+    docker_args += [f"{CONTAINER_PREFIX}:{tag}",
                     "/usr/local/bin/init-container.sh"]
     print("Launching docker with args %s" % docker_args, file=sys.stderr)
     return subprocess.call(docker_args)

src/xcp_ng_dev/files/Dockerfile-9.x

@@ -2,6 +2,7 @@ FROM    ghcr.io/almalinux/10-base:10.0
 
 ARG     CUSTOM_BUILDER_UID=""
 ARG     CUSTOM_BUILDER_GID=""
+ARG     BOOTSTRAP=0
 
 # Add our repositories
 # temporary bootstrap repository
@@ -12,6 +13,11 @@ COPY    files/Alma10-devel.repo /etc/yum.repos.d/
 # Install GPG key
 RUN     curl -sSf https://xcp-ng.org/RPM-GPG-KEY-xcpng -o /etc/pki/rpm-gpg/RPM-GPG-KEY-xcpng
 
+# dnf config-manager not available yet?
+RUN     if [ "${BOOTSTRAP}" = 1 ]; then \
+            sed -i -e 's/^enabled=1$/enabled=0/' /etc/yum.repos.d/xcp-ng.repo; \
+        fi
+
 # Update
 RUN     dnf update -y
 
@@ -43,11 +49,12 @@ RUN     dnf install -y \
 # clean package cache to avoid download errors
 RUN     yum clean all
 
-# -release*, to be commented out to boostrap the build-env until it gets built
 # FIXME: isn't it already pulled as almalinux-release when available?
-RUN     dnf install -y \
-            xcp-ng-release \
-            xcp-ng-release-presets
+RUN     if [ "${BOOTSTRAP}" = 0 ]; then \
+            dnf install -y \
+                xcp-ng-release \
+                xcp-ng-release-presets ; \
+        fi
 
 # enable repositories commonly required to build
 RUN     dnf config-manager --enable crb