Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

建议去掉prometheus requests cost histogram指标的trace_id参数，极大影响性能 #80

Open
ZoMinster opened this issue Jul 13, 2022 · 2 comments
Open

建议去掉prometheus requests cost histogram指标的trace_id参数，极大影响性能 #80

ZoMinster opened this issue Jul 13, 2022 · 2 comments

Comments

@ZoMinster
Copy link

image
建议去掉prometheus requests cost histogram指标的trace_id label，极大影响性能，而且这个label在这里用处不大
@ZoMinster
Copy link
Author

cost_milliseconds 也可以去掉

@ZoMinster
Copy link
Author

ZoMinster commented Jul 14, 2022 •
edited
Loading

histogram 指标会统计请求时间在各个耗时段的请求个数，如图
image 加了trace_id 和 cost_milliseconds 这个两个基本每个请求都是不一样，这样所有的耗时段的请求个数最多就1，导致指标个数很多，损耗性能，同时也失去了这个统计的意义

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ZoMinster