Corrected typo in GIF header generation, fixes #2

philklc · web-flow · commit 76197caa3c1d · 2017-10-25T12:37:24.000+08:00
Also corrected is the loop value which should be zero based.
diff --git a/src/GifCreator/AnimGif.php b/src/GifCreator/AnimGif.php
@@ -302,7 +302,7 @@ protected function gifAddHeader()
 			$this->gif .= substr($this->frameSources[0], 6, 7);
 			$this->gif .= substr($this->frameSources[0], 13, $cmap);
 			if ($this->loop !== 1) // Only add the looping extension if really looping
-				$this->gif .= "!\xFF\x0BNETSCAPE2.0\0x03\0x01".word2bin($this->loop)."\x0";
+				$this->gif .= "!\xFF\x0BNETSCAPE2.0\x03\x01".word2bin($this->loop==0?0:$this->loop-1)."\x0";
 		}
 	}
     

Original file line number	Diff line number	Diff line change
`@@ -302,7 +302,7 @@ protected function gifAddHeader()`
`302`	`302`	`$this->gif .= substr($this->frameSources[0], 6, 7);`
`303`	`303`	`$this->gif .= substr($this->frameSources[0], 13, $cmap);`
`304`	`304`	`if ($this->loop !== 1) // Only add the looping extension if really looping`
`305`		`- $this->gif .= "!\xFF\x0BNETSCAPE2.0\0x03\0x01".word2bin($this->loop)."\x0";`
	`305`	`+ $this->gif .= "!\xFF\x0BNETSCAPE2.0\x03\x01".word2bin($this->loop==0?0:$this->loop-1)."\x0";`
`306`	`306`	`}`
`307`	`307`	`}`
`308`	`308`