-
-
Notifications
You must be signed in to change notification settings - Fork 606
XWIKI-23546: Improve usability of document tree macro configuration #4612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Provide grouping and ordering of various parameters
|
Some things that could be reworked if possible:
Otherwise, seems fine the way it is. |
I agree that some hints are too long and can be simplified (no more than 2 lines of text ideally). Furthermore, just by looking at the screenshots, I would:
|
mflorea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, my only comment is the one posted above.
Thanks for the review. I would keep displaying "Optional parameters" first: IMO the first parameters (root / open to / limit / sort by) are probably the most used parameters and that's why I decided to fix their order. Unless I can find a common group name for them. I will check for ordering of the other tabs.
OK I'll do that for Exclusions / Expand to. For sort I'd keep it in first tab to be quickly available.
Yeah they probably need some work, I'll see if I can improve them a bit, otherwise it could be done later. |
* Improve a bit the changes after review
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Jira URL
https://jira.xwiki.org/browse/XWIKI-23546
Changes
Description
Clarifications
Screenshots & Video
Before
After
Executed Tests
mvn clean install -Pquality,integration-tests,dockeron modulexwiki-platform-index-tree. Should be enough: we don't have any integration tests manipulating the macro config UI.Expected merging strategy