Keyboard shortcuts from navigating to the top/bottom of the page don't update the log event number

[kirkrodrigues]

Bug

The CTRL + U/I keyboard shortcuts navigate to the top and bottom of the current page, but they don't update the log event number.

yscope-log-viewer version

bc8109f

Environment

• Windows 11
• Firefox 131.0.3 (64-bit)

Reproduction steps

• Open a file in the log viewer
• CTRL + I to navigate to the bottom of the page (observe the log event number doesn't change from its initial value)

[aestriplex]

@kirkrodrigues I found this little bug and I made some tiny changes to fix it. Now pressing CTRL+u / CTRL+i will set the logEventNum both in the url and at the bottom of the page.

I still have a couple of questions:

• I guess there is no longer a need for a blank line at the bottom of the editor page (line 10001). Is this correct?
• In the React component I have modified I saw this:

if ("undefined" === typeof lineCount) {
    break;
}

Wasn't it sufficient to check

if (!lineCount) {
    break;
}