Update CI for rubocop and fix lint issues

Author: Envek

.github/workflows/lint.yml

@@ -3,7 +3,9 @@ name: Lint Ruby
 on:
   push:
     branches:
-      - master
+      - '**'
+    tags-ignore:
+      - 'v*'
     paths:
       - "gemfiles/*"
       - "Gemfile"
@@ -20,12 +22,15 @@ on:
 
 jobs:
   rubocop:
+    # Skip running tests for local pull requests (use push event instead), run only for foreign ones
+    if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.owner.login != github.event.pull_request.base.repo.owner.login
+    name: RuboCop
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 3.2
+        ruby-version: "3.3"
         bundler-cache: true
     - name: Lint Ruby code with RuboCop
       run: |

Gemfile

@@ -16,6 +16,6 @@ group :development, :test do
   gem "pry"
   gem "pry-byebug", platform: :mri
 
-  gem "rubocop", "~> 1.0"
-  gem "rubocop-rspec"
+  gem "rubocop", "~> 1.0", require: false
+  gem "rubocop-rspec", require: false
 end

lib/yabeda.rb

@@ -67,7 +67,7 @@ def default_tags
     def register_adapter(name, instance)
       adapters[name] = instance
       # NOTE: Pretty sure there is race condition
-      metrics.each do |_, metric|
+      metrics.each_value do |metric|
         instance.register!(metric)
       end
     end

lib/yabeda/counter.rb

@@ -6,7 +6,7 @@ class Counter < Metric
     def increment(tags, by: 1)
       all_tags = ::Yabeda::Tags.build(tags, group)
       values[all_tags] += by
-      ::Yabeda.adapters.each do |_, adapter|
+      ::Yabeda.adapters.each_value do |adapter|
         adapter.perform_counter_increment!(self, all_tags, by)
       end
       values[all_tags]

lib/yabeda/gauge.rb

@@ -6,7 +6,7 @@ class Gauge < Metric
     def set(tags, value)
       all_tags = ::Yabeda::Tags.build(tags, group)
       values[all_tags] = value
-      ::Yabeda.adapters.each do |_, adapter|
+      ::Yabeda.adapters.each_value do |adapter|
         adapter.perform_gauge_set!(self, all_tags, value)
       end
       value

lib/yabeda/histogram.rb

@@ -20,7 +20,7 @@ def measure(tags, value = nil)
 
       all_tags = ::Yabeda::Tags.build(tags, group)
       values[all_tags] = value
-      ::Yabeda.adapters.each do |_, adapter|
+      ::Yabeda.adapters.each_value do |adapter|
         adapter.perform_histogram_measure!(self, all_tags, value)
       end
       value

lib/yabeda/summary.rb

@@ -18,7 +18,7 @@ def observe(tags, value = nil)
 
       all_tags = ::Yabeda::Tags.build(tags, group)
       values[all_tags] = value
-      ::Yabeda.adapters.each do |_, adapter|
+      ::Yabeda.adapters.each_value do |adapter|
         adapter.perform_summary_observe!(self, all_tags, value)
       end
       value

spec/spec_helper.rb

@@ -17,6 +17,9 @@
     c.syntax = :expect
   end
 
+  config.filter_run focus: true
+  config.run_all_when_everything_filtered = true
+
   config.after do
     Yabeda.reset! # Undo call to +Yabeda.configure!+
   end