Skip to content

Commit c645d88

Browse files
authored
Merge pull request #1383 run experimental tests on nightly ydb image
2 parents 91cf42d + e54b96e commit c645d88

File tree

3 files changed

+3
-13
lines changed

3 files changed

+3
-13
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ jobs:
102102
fail-fast: false
103103
matrix:
104104
go-version: [1.22.x]
105-
ydb-version: [24.1]
105+
ydb-version: [nightly]
106106
services:
107107
ydb:
108108
image: ydbplatform/local-ydb:${{ matrix.ydb-version }}

tests/integration/database_sql_static_credentials_test.go

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import (
1818

1919
"github.com/ydb-platform/ydb-go-sdk/v3"
2020
"github.com/ydb-platform/ydb-go-sdk/v3/credentials"
21-
"github.com/ydb-platform/ydb-go-sdk/v3/internal/version"
2221
)
2322

2423
func TestDatabaseSqlStaticCredentials(t *testing.T) {
@@ -37,11 +36,7 @@ func TestDatabaseSqlStaticCredentials(t *testing.T) {
3736
t.Fatal(err)
3837
}
3938

40-
if version.Gte(os.Getenv("YDB_VERSION"), "23.3") {
41-
u.User = url.UserPassword("root", "1234")
42-
} else {
43-
u.User = url.User("root")
44-
}
39+
u.User = url.UserPassword("root", "1234")
4540

4641
t.Run("sql.Open", func(t *testing.T) {
4742
var db *sql.DB

tests/integration/static_credentials_test.go

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import (
1717

1818
"github.com/ydb-platform/ydb-go-sdk/v3"
1919
"github.com/ydb-platform/ydb-go-sdk/v3/credentials"
20-
"github.com/ydb-platform/ydb-go-sdk/v3/internal/version"
2120
)
2221

2322
func TestStaticCredentials(t *testing.T) {
@@ -36,11 +35,7 @@ func TestStaticCredentials(t *testing.T) {
3635
t.Fatal(err)
3736
}
3837

39-
if version.Gte(os.Getenv("YDB_VERSION"), "23.3") {
40-
u.User = url.UserPassword("root", "1234")
41-
} else {
42-
u.User = url.User("root")
43-
}
38+
u.User = url.UserPassword("root", "1234")
4439

4540
staticCredentials := credentials.NewStaticCredentials(u.User.Username(), func() string {
4641
password, _ := u.User.Password()

0 commit comments

Comments
 (0)