Skip to content

Commit 71bd738

Browse files
authored
Merge pull request #529 from ydb-platform/fix_writer_created_at_tz
Make created_at utc in topic writer
2 parents 052ccbc + 535b3e8 commit 71bd738

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

ydb/_topic_reader/topic_reader_asyncio_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -748,7 +748,7 @@ async def test_free_buffer_after_partition_stop(self, stream, stream_reader, par
748748
initial_buffer_size = stream_reader._buffer_size_bytes
749749
message_size = initial_buffer_size - 1
750750

751-
t = datetime.datetime.now()
751+
t = datetime.datetime.now(datetime.timezone.utc)
752752

753753
stream.from_server.put_nowait(
754754
StreamReadMessage.FromServer(

ydb/_topic_writer/topic_writer_asyncio.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ def _add_messages_to_send_queue(self, internal_messages: List[InternalMessage]):
307307

308308
def _prepare_internal_messages(self, messages: List[PublicMessage]) -> List[InternalMessage]:
309309
if self._settings.auto_created_at:
310-
now = datetime.datetime.now()
310+
now = datetime.datetime.now(datetime.timezone.utc)
311311
else:
312312
now = None
313313

ydb/_topic_writer/topic_writer_asyncio_test.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ async def test_init_writer(self, stream):
132132

133133
async def test_write_a_message(self, writer_and_stream: WriterWithMockedStream):
134134
data = "123".encode()
135-
now = datetime.datetime.now()
135+
now = datetime.datetime.now(datetime.timezone.utc)
136136
writer_and_stream.writer.write(
137137
[
138138
InternalMessage(
@@ -322,7 +322,7 @@ async def test_reconnect_and_resent_non_acked_messages_on_retriable_error(
322322
get_stream_writer,
323323
default_write_statistic,
324324
):
325-
now = datetime.datetime.now()
325+
now = datetime.datetime.now(datetime.timezone.utc)
326326
data = "123".encode()
327327

328328
message1 = PublicMessage(
@@ -460,7 +460,7 @@ async def test_deny_double_seqno(self, reconnector: WriterAsyncIOReconnector, ge
460460

461461
@freezegun.freeze_time("2022-01-13 20:50:00", tz_offset=0)
462462
async def test_auto_created_at(self, default_driver, default_settings, get_stream_writer):
463-
now = datetime.datetime.now()
463+
now = datetime.datetime.now(datetime.timezone.utc)
464464

465465
settings = copy.deepcopy(default_settings)
466466
settings.auto_created_at = True
@@ -587,7 +587,7 @@ async def test_custom_encoder(self, default_driver, default_settings, get_stream
587587
settings.codec = codec
588588
reconnector = WriterAsyncIOReconnector(default_driver, settings)
589589

590-
now = datetime.datetime.now()
590+
now = datetime.datetime.now(datetime.timezone.utc)
591591
seqno = self.init_last_seqno + 1
592592

593593
await reconnector.write_with_ack_future([PublicMessage(data=b"123", seqno=seqno, created_at=now)])

0 commit comments

Comments
 (0)