Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize sync requests in push-only syncMode to avoid unnecessary syncs #816

Open
chacha912 opened this issue May 22, 2024 · 0 comments
Open

Optimize sync requests in push-only syncMode to avoid unnecessary syncs #816

chacha912 opened this issue May 22, 2024 · 0 comments
Labels
bug 🐞 Something isn't working cleanup 🧹 Paying off technical debt sdk ⚒️

Comments

@chacha912
Copy link
Contributor

What happened:

Sync requests are being triggered by remote changes even when syncmode is set to pushonly and there are no local changes.

What you expected to happen:

When syncmode is set to pushonly and there are no local changes, sync requests should not be triggered by remote changes.

How to reproduce it (as minimally and precisely as possible):

  1. clientA: Set syncmode to pushonly.
  2. clientA: Ensure there are no local changes.
  3. clientB: Edit document.
  4. clientA: Observe that a sync request is still triggered.

Anything else we need to know?:

Environment:

  • Operating system:
  • Browser and version:
  • Yorkie version (use yorkie version):
  • Yorkie JS SDK version:
@chacha912 chacha912 added bug 🐞 Something isn't working cleanup 🧹 Paying off technical debt labels May 22, 2024
@chacha912 chacha912 mentioned this issue May 23, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞 Something isn't working cleanup 🧹 Paying off technical debt sdk ⚒️
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hackerwins @chacha912