You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description:
During the process of performing a range deletion operation, if there are nodes within the range that have already been removed, the removedAt field should be updated accordingly.
Locally, there is no need to update removedAt for nodes that are already marked as removed. However, when considering remote scenarios, it is necessary to update removedAt. Currently, the logic does not update removedAt for either treeNode or textNode.
In more detail, when collecting nodes within a range, the logic for treeNode filters out nodes that are already marked as removed(see tokensBetween() and children()), while textNode performs a similar role through the canDelete().
What you expected to happen:
The removedAt field should be updated for nodes that have already been deleted when performing a range deletion operation.
How to reproduce it (as minimally and precisely as possible):
This issue works normally in the current spec, but will recur when undo/redo is added in the future.
Anything else we need to know?:
N/A
Environment:
Operating system: N/A
Browser and version: N/A
Yorkie version (use yorkie version): N/A
Yorkie JS SDK version: v0.4.20
The text was updated successfully, but these errors were encountered:
Description:
During the process of performing a range deletion operation, if there are nodes within the range that have already been removed, the
removedAt
field should be updated accordingly.Locally, there is no need to update
removedAt
for nodes that are already marked as removed. However, when considering remote scenarios, it is necessary to updateremovedAt
. Currently, the logic does not updateremovedAt
for eithertreeNode
ortextNode
.In more detail, when collecting nodes within a range, the logic for
treeNode
filters out nodes that are already marked as removed(seetokensBetween()
andchildren()
), whiletextNode
performs a similar role through thecanDelete()
.What you expected to happen:
The
removedAt
field should be updated for nodes that have already been deleted when performing a range deletion operation.How to reproduce it (as minimally and precisely as possible):
This issue works normally in the current spec, but will recur when undo/redo is added in the future.
Anything else we need to know?:
N/A
Environment:
yorkie version
): N/AThe text was updated successfully, but these errors were encountered: