Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set window/application name #115

Open
bsonntag opened this issue Dec 4, 2017 · 4 comments
Open

Properly set window/application name #115

bsonntag opened this issue Dec 4, 2017 · 4 comments

Comments

@bsonntag
Copy link

bsonntag commented Dec 4, 2017

Instead of leaving "Electron" as the name, please set it to "vmd".

@maxkueng
Copy link
Collaborator

maxkueng commented Dec 4, 2017

Hi. Can you be more specific as to where it still shows "Electron"? Or maybe provide a screenshot?

If relevant:

  • Which OS and version are you using?
  • Did you install vmd through npm or did you use a packaged build from the releases page?

@bsonntag
Copy link
Author

bsonntag commented Dec 5, 2017

I'm using macOS High Sierra and I installed vmd through npm.

Screenshot:

screen shot 2017-12-05 at 10 44 15

It also displays "Electron" and the Electron icon when doing cmd+tab.

@maxkueng
Copy link
Collaborator

maxkueng commented Jun 2, 2018

Thanks for the inputs. I don't have a Mac machine to try this so if you want this fixed it's be great if you could submit a pull request.

@bsonntag
Copy link
Author

I dug a bit into this issue and found out that it's impossible to change the application name on the Mac OS menu when running with electron.

To fix this issue, vmd would have to include a packaged version of the app when installed via npm (or run with npx) or package the app on installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants