Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Wait before updating (percentage) #758

Open
barraIhsan opened this issue Feb 20, 2025 · 3 comments
Open

[Feature Request] Wait before updating (percentage) #758

barraIhsan opened this issue Feb 20, 2025 · 3 comments

Comments

@barraIhsan
Copy link

I would prefer to mark the episode as "watched" when I watch at least 85% of them and not 120 sesconds (the default Wait before updating (seconds) default value) into the video which means just in the beginning. I could put something like 1200 to set it to 15 minutes, but that's not ideal as not all episodes are 20-ish minutes and what about the case of movies. That's why I would like to suggest introducing percentage value. Just like MALSync does

Image

@z411
Copy link
Owner

z411 commented Feb 20, 2025

For this to work we would need to get the duration of the media file; the MPRIS tracker for sure must be able to do this, but file-based trackers like inotify would be left out.

May I ask how MALSync gets/calculates this?

@barraIhsan
Copy link
Author

May I ask how MALSync gets/calculates this?

I dont really know but, MALSync probably calculate it from the seekbar from each website (since it's a web tracker)

MPRIS tracker for sure must be able to do this,

Yes

but file-based trackers like inotify would be left out.

or maybe, fallback to that, when we FINISHED watching the episode, then the tracker increment (not Wait until the player is closed)

@FichteFoll
Copy link
Collaborator

FichteFoll commented Feb 21, 2025

This was definitely discussed in an issue or PR before, but I couldn't find it just now and having a dedicated and findable issue doesn't hurt, ofc.

It's been somewhat on my radar as well, but the tracker code could use some cleanup before we add more logic to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants