You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A common problem here is that x86 is still using i386's extended-precision 80-bit floating point arithmetic by default, so the results are more precise than they actually should be with 64-bit FP. This can be disabled by adding the -ffp-contract=off compiler flag. However, this doesn't work here (the test still passes on x86), possibly the same would have to be applied on the PostGIS side as well.
One fix might be to tweak the "epsilon" value used (but playing with it for a moment didn't work, I don't quite understand that test yet).
(I disabled that test for the Debian package build for now, so h3-pg is up-to-date on apt.postgresql.org and in Debian now.)
The text was updated successfully, but these errors were encountered:
I think lowering epsilon until the test pass is an acceptable solution. I didn't actually make that particular test, but I think the current value was chosen somewhat arbitrarily.
I would love to automate testing for this, but I don't believe I can choose architecture for GitHub runners. 🤔 I would be very grateful if you could help figure out many zeroes to remove such that the test pass on other architectures.
The "check latitude of antimeridian crossing points" test in h3_postgis/test/sql/postgis.sql is failing on all architectures except x68:
https://jengus.postgresql.org/job/h3-pg-binaries/20/
A common problem here is that x86 is still using i386's extended-precision 80-bit floating point arithmetic by default, so the results are more precise than they actually should be with 64-bit FP. This can be disabled by adding the
-ffp-contract=off
compiler flag. However, this doesn't work here (the test still passes on x86), possibly the same would have to be applied on the PostGIS side as well.One fix might be to tweak the "epsilon" value used (but playing with it for a moment didn't work, I don't quite understand that test yet).
(I disabled that test for the Debian package build for now, so h3-pg is up-to-date on apt.postgresql.org and in Debian now.)
The text was updated successfully, but these errors were encountered: