Enforce sensitive Package Variable policy#146
Merged
Conversation
Reject sensitive Package Variable defaults across template manifests, install snapshots, declaration merging, and runtime resolution. Share sensitive value redaction for vars explain output and cover doctor diagnostics against inline sensitive value leaks. Validation: mise run fix; mise run ci; sh ./scripts/test_release_surface_hyard.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linked Issue
Closes #139
Dev Brief Mapping
sensitiveand rejectsensitive: truedeclarations that also definedefault.valueorvalue_from.file.value_from.envwhen the referenced environment variable is present.hyard vars doctorreports sensitive policy violations as errors.hyard vars explainredacts sensitive values in text and JSON output while still reporting selected source and resolved status.What Changed
vars explainthrough it.hyard vars doctorno-leak diagnostic case.Validation
mise run fixmise run cish ./scripts/test_release_surface_hyard.shhyardrelease-surface smoke checks passed.Risk
Out of Scope
Reviewer Notes
src-git/inside the Symphony issue workspace because the root issue workspace Git metadata was locked against fetch/ref/index writes. The branch is pushed from the nested clone against currentmain.