Skip to content

Commit 5ae442e

Browse files
d-v-bclaude
andcommitted
fix: address roborev branch-review findings
Two low-severity findings from the branch review: - releases.yml: the `verify_pypi_dependency` failure diagnostics wrapped `>=` in backticks inside double-quoted echo strings, so bash ran `>=` as command substitution — dropping `>=` from the message and creating a stray `=` file. Switch to single quotes with the requirement passed as a separate argument. - core/metadata/v2.py: the "Re-export ... historical name" comment sat above an unrelated `parse_separator` import. Move it to the `ArrayV2MetadataDict = _ArrayMetadataV2` assignment it actually describes. The third finding (pyright via uvx possibly not resolving src imports) was verified as a non-issue: the zarr-metadata pyright CI job passes on the current branch tip. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 1a54a49 commit 5ae442e

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

.github/workflows/releases.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,8 @@ jobs:
146146
| head -1)"
147147
148148
if [ -z "$floor" ]; then
149-
echo "::error::Could not extract a `>=` floor from: $req_line"
150-
echo "zarr-python's zarr-metadata requirement must include a `>=` bound so this gate has something to check."
149+
echo '::error::Could not extract a >= floor from:' "$req_line"
150+
echo "zarr-python's zarr-metadata requirement must include a >= bound so this gate has something to check."
151151
exit 1
152152
fi
153153
echo "zarr-metadata floor: $floor"

src/zarr/core/metadata/v2.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@
3232
from zarr_metadata.v2.array import ArrayMetadataV2 as _ArrayMetadataV2
3333

3434
from zarr.core.array_spec import ArrayConfig, ArraySpec
35-
36-
# Re-export the v2 array metadata JSON shape under zarr-python's historical name.
3735
from zarr.core.chunk_key_encodings import parse_separator
3836
from zarr.core.common import (
3937
JSON,
@@ -47,6 +45,7 @@
4745

4846
# Union of acceptable types for v2 compressors
4947
type CompressorLikev2 = dict[str, JSON] | Numcodec | None
48+
# Re-export the v2 array metadata JSON shape under zarr-python's historical name.
5049
ArrayV2MetadataDict = _ArrayMetadataV2
5150

5251

0 commit comments

Comments
 (0)