Commit 5ae442e
fix: address roborev branch-review findings
Two low-severity findings from the branch review:
- releases.yml: the `verify_pypi_dependency` failure diagnostics wrapped `>=`
in backticks inside double-quoted echo strings, so bash ran `>=` as command
substitution — dropping `>=` from the message and creating a stray `=` file.
Switch to single quotes with the requirement passed as a separate argument.
- core/metadata/v2.py: the "Re-export ... historical name" comment sat above
an unrelated `parse_separator` import. Move it to the
`ArrayV2MetadataDict = _ArrayMetadataV2` assignment it actually describes.
The third finding (pyright via uvx possibly not resolving src imports) was
verified as a non-issue: the zarr-metadata pyright CI job passes on the
current branch tip.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 1a54a49 commit 5ae442e
2 files changed
Lines changed: 3 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
146 | 146 | | |
147 | 147 | | |
148 | 148 | | |
149 | | - | |
150 | | - | |
| 149 | + | |
| 150 | + | |
151 | 151 | | |
152 | 152 | | |
153 | 153 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
36 | | - | |
37 | 35 | | |
38 | 36 | | |
39 | 37 | | |
| |||
47 | 45 | | |
48 | 46 | | |
49 | 47 | | |
| 48 | + | |
50 | 49 | | |
51 | 50 | | |
52 | 51 | | |
| |||
0 commit comments