Skip to content

Commit e9fb1f3

Browse files
authored
remove blosc warnings from n5 compressor handling (#1331)
* remove blosc warnings from n5 compressor handling * release notes * remove reference to n5 warnings in pytest ini options * remove blosc from list of warned compressors in tests, and restore lzma warning
1 parent c714d2b commit e9fb1f3

File tree

4 files changed

+4
-11
lines changed

4 files changed

+4
-11
lines changed

docs/release.rst

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,9 @@ Major changes
2525
* sharding storage transformer
2626
By :user:`Jonathan Striebel <jstriebel>`; :issue:`1096`, :issue:`1111`.
2727

28-
28+
* Remove warnings emitted when using N5Store or N5FSStore with a blosc-compressed array.
29+
By :user:`Davis Bennett <d-v-b>`; :issue:`1331`.
30+
2931
Bug fixes
3032
~~~~~~~~~
3133

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ addopts = [
8787
]
8888
filterwarnings = [
8989
"error:::zarr.*",
90-
"ignore:Not all N5 implementations support blosc compression.*:RuntimeWarning",
9190
"ignore:PY_SSIZE_T_CLEAN will be required.*:DeprecationWarning",
9291
"ignore:The loop argument is deprecated since Python 3.8.*:DeprecationWarning",
9392
]

zarr/n5.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -735,12 +735,6 @@ def compressor_config_to_n5(compressor_config: Optional[Dict[str, Any]]) -> Dict
735735

736736
elif codec_id == 'blosc':
737737

738-
warnings.warn(
739-
"Not all N5 implementations support blosc compression (yet). You "
740-
"might not be able to open the dataset with another N5 library.",
741-
RuntimeWarning
742-
)
743-
744738
n5_config['cname'] = _compressor_config['cname']
745739
n5_config['clevel'] = _compressor_config['clevel']
746740
n5_config['shuffle'] = _compressor_config['shuffle']

zarr/tests/test_core.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2022,9 +2022,7 @@ def test_compressors(self):
20222022
a1[:] = 1
20232023
assert np.all(a1[:] == 1)
20242024

2025-
compressors_warn = [
2026-
Blosc()
2027-
]
2025+
compressors_warn = []
20282026
if LZMA:
20292027
compressors_warn.append(LZMA(2)) # Try lzma.FORMAT_ALONE, which N5 doesn't support.
20302028
for compressor in compressors_warn:

0 commit comments

Comments
 (0)