You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When opening a zarr using s3fs, some errors related to aiohttp objects are raised when leaving the Python interpreter. From what I understand, it seems that cleaning asynchronous objects should be performed by the filestorage implementation, as in #2674 (comment).
However it is unclear to me if this should be performed by zarr_python or the s3fs implementation, as discussed here : fsspec/s3fs#943.
The tricky bit here is that zarr-python doesn't really know who owns the filesystem passed into FsspecStore. We don't necessarily want to close it, since the user might be using it outside of zarr.
Maybe we could make FsspecStore (and the related stores) async context managers and have then close the store upon __aexit__?
Zarr version
v3.X
Numcodecs version
v0.15.1
Python Version
3.12
Operating System
Linux
Installation
pip into venv
Description
When opening a zarr using s3fs, some errors related to
aiohttp
objects are raised when leaving the Python interpreter. From what I understand, it seems that cleaning asynchronous objects should be performed by the filestorage implementation, as in #2674 (comment).However it is unclear to me if this should be performed by zarr_python or the s3fs implementation, as discussed here : fsspec/s3fs#943.
What do you think ?
Steps to reproduce
Should raise the following error :
Additional output
No response
The text was updated successfully, but these errors were encountered: