Skip to content

Phpactor does not work under Windows because .phar files are not executable #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
exi opened this issue Apr 20, 2025 · 1 comment · May be fixed by #25
Open

Phpactor does not work under Windows because .phar files are not executable #23

exi opened this issue Apr 20, 2025 · 1 comment · May be fixed by #25
Labels
good first issue Good for newcomers windows

Comments

@exi
Copy link

exi commented Apr 20, 2025

Under Windows, .phar files need to be executed with the php interpreter.
Executing the .phar file directly fails.
@exi exi changed the title Extension does not work under Windows because .phar files are not executable Phpactor does not work under Windows because .phar files are not executable Apr 20, 2025
@notpeter notpeter added windows good first issue Good for newcomers labels Apr 24, 2025
@notpeter
Copy link
Contributor

Thanks for reporting, that makes sense.
Phar archives include a #!/usr/bin/env php shebang which doesn't work on windows.

It should be relatively easy to match on zed_extension_api::current_platform() and return a window specific command/arguments.

imblowsnow added a commit to fork-mine/php that referenced this issue Apr 26, 2025
@imblowsnow
fix: zed-extensions#23
32959c8
@imblowsnow imblowsnow linked a pull request Apr 26, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix launching phpactor.phar on windows fork-mine/php
2 participants
@notpeter @exi