BodyParamsMiddleware: Valid JSON containing a scalar value causes InvalidArgumentException

[ketners]

If the request body contains a valid scalar JSON value e.g. string, boolean or int, an InvalidArgumentException is thrown.

Code to reproduce the issue

Using BodyParamsMiddleware with the standard JsonStartegy.

Like described here: https://docs.zendframework.com/zend-expressive/v3/features/helpers/body-parse/

Send a request with the Content-Type header 'application/json' and the body containing any of this:

• "string"
• false
• true
• 123

Expected results

Expecting to use \Psr\Http\Message\ServerRequestInterface::getParsedBody().

Actual results

InvalidArgumentException
Zend\Diactoros\ServerRequest::withParsedBody expects a null, array, or object argument; received integer

[geerteltink]

@mrkey Can you create a test case? I can't reproduce it here.

[ketners]

Steps to reproduce:

1. Create the default zend skeleton app like described here: https://docs.zendframework.com/zend-expressive/v3/getting-started/quick-start/
   1.1) all defaults
   1.2) run webserver
2. Modify config/routes.php to add a POST route along the two default get routes:

return function (Application $app, MiddlewareFactory $factory, ContainerInterface $container) : void {
    $app->get('/', App\Handler\HomePageHandler::class, 'home');
    $app->post('/', [Zend\Expressive\Helper\BodyParams\BodyParamsMiddleware::class, App\Handler\HomePageHandler::class]);
    $app->get('/api/ping', App\Handler\PingHandler::class, 'api.ping');
};

3. Make a request with the 'Content-Type: application/json' header and with the body '2' (without any braces):

POST  HTTP/1.1
Host: localhost:8080
Content-Type: application/json

2

Result:

Zend\Diactoros\Exception\InvalidArgumentException: Zend\Diactoros\ServerRequest::withParsedBody expects a null, array, or object argument; received integer in file ...

[geerteltink]

Shouldn't you pass valid json? Let me rephrase that...

It is valid json I guess. But as the Exception message says, it expects that json_decode returns null, array or object. json_decode(2, true) returns an integer as the exception tells you.

To have json_decode return something useful, you need to feed it something that translates to an array: {"data":2}.

[weierophinney]

This repository has been closed and moved to mezzio/mezzio-helpers; a new issue has been opened at mezzio/mezzio-helpers#1.