withoutPersisting schedules for insert in Doctrine UnitOfWork

[tandev]

Hi, im unsureif it was introduced in the latest 2.3.2 version, but it seems like persistance is inconsistently handled.

Factories that have persistence disabled, are still scheduling for insert for children.

 $contact = static::contactFactory()->withoutPersisting()->create([
            'tags' => static::tagFactory()::new()->many(3),
            'category' => static::categoryFactory(),
        ]);

This can be observed in the \Zenstruck\Foundry\Tests\Integration\ORM\EntityRelationship\EntityFactoryRelationshipTestCase::disabling_persistence_cascades_to_children test by checking the UnitOfWork insertions

Unless withoutPersisting is not the same meaning as in doctrine, let me know if i misunderstood something here

        foreach ($contact->getTags() as $tag) {
            $this->assertNull($tag->id);
++            static::assertFalse(Configuration::instance()->persistence()->isPersisted($tag));
        }

i tested if i can enhance the test by a isPersisted check, but this is always returning false despite being scheduled for insert by doctrine

[nikophil]

Yeah, we should add a flush() in the test where you took the example to assert nothing is passed to the UoW.

I'll fix that in few days as well

[nikophil]

@tandev would you mind to test if #817 fixes the problem in your project? It actually fixes it in our test

[tandev]

Hi. looks good, we had setup some entities withoutPersisting() for reference and those get not tried to be persisted anymore