Skip to content

Commit 9b36dbc

Browse files
committed
tests: stepper: drv84xx: deleting outdated/duplicated tests
Removing tests which are already covered in stepper api test suite or are outdated and have no relevance in accordance to the recent changes in the api Signed-off-by: Jilay Pandya <[email protected]>
1 parent 9e54590 commit 9b36dbc

File tree

2 files changed

+3
-82
lines changed
  • tests/drivers/stepper

2 files changed

+3
-82
lines changed

tests/drivers/stepper/drv84xx/api/src/main.c

Lines changed: 0 additions & 80 deletions
Original file line numberDiff line numberDiff line change
@@ -87,66 +87,6 @@ ZTEST_F(drv84xx_api, test_actual_position_set)
8787
zassert_equal(pos, 100u, "Actual position should be %u but is %u", 100u, pos);
8888
}
8989

90-
ZTEST_F(drv84xx_api, test_move_to_positive_direction_movement)
91-
{
92-
int32_t pos = 50;
93-
94-
(void)stepper_enable(fixture->dev);
95-
(void)stepper_set_microstep_interval(fixture->dev, 20000000);
96-
(void)stepper_set_event_callback(fixture->dev, fixture->callback, NULL);
97-
(void)stepper_move_to(fixture->dev, pos);
98-
(void)k_poll(&stepper_event, 1, K_SECONDS(5));
99-
unsigned int signaled;
100-
int result;
101-
102-
k_poll_signal_check(&stepper_signal, &signaled, &result);
103-
zassert_equal(signaled, 1, "No event detected");
104-
zassert_equal(result, STEPPER_EVENT_STEPS_COMPLETED,
105-
"Event was not STEPPER_EVENT_STEPS_COMPLETED event");
106-
(void)stepper_get_actual_position(fixture->dev, &pos);
107-
zassert_equal(pos, 50u, "Target position should be %d but is %d", 50u, pos);
108-
}
109-
110-
ZTEST_F(drv84xx_api, test_move_to_negative_direction_movement)
111-
{
112-
int32_t pos = -50;
113-
114-
(void)stepper_enable(fixture->dev);
115-
(void)stepper_set_microstep_interval(fixture->dev, 20000000);
116-
(void)stepper_set_event_callback(fixture->dev, fixture->callback, NULL);
117-
(void)stepper_move_to(fixture->dev, pos);
118-
(void)k_poll(&stepper_event, 1, K_SECONDS(5));
119-
unsigned int signaled;
120-
int result;
121-
122-
k_poll_signal_check(&stepper_signal, &signaled, &result);
123-
zassert_equal(signaled, 1, "No event detected");
124-
zassert_equal(result, STEPPER_EVENT_STEPS_COMPLETED,
125-
"Event was not STEPPER_EVENT_STEPS_COMPLETED event");
126-
(void)stepper_get_actual_position(fixture->dev, &pos);
127-
zassert_equal(pos, -50, "Target position should be %d but is %d", -50, pos);
128-
}
129-
130-
ZTEST_F(drv84xx_api, test_move_to_identical_current_and_target_position)
131-
{
132-
int32_t pos = 0;
133-
134-
(void)stepper_enable(fixture->dev);
135-
(void)stepper_set_microstep_interval(fixture->dev, 20000000);
136-
(void)stepper_set_event_callback(fixture->dev, fixture->callback, NULL);
137-
(void)stepper_move_to(fixture->dev, pos);
138-
(void)k_poll(&stepper_event, 1, K_SECONDS(5));
139-
unsigned int signaled;
140-
int result;
141-
142-
k_poll_signal_check(&stepper_signal, &signaled, &result);
143-
zassert_equal(signaled, 1, "No event detected");
144-
zassert_equal(result, STEPPER_EVENT_STEPS_COMPLETED,
145-
"Event was not STEPPER_EVENT_STEPS_COMPLETED event");
146-
(void)stepper_get_actual_position(fixture->dev, &pos);
147-
zassert_equal(pos, 0, "Target position should not have changed from %d but is %d", 0, pos);
148-
}
149-
15090
ZTEST_F(drv84xx_api, test_move_to_is_moving_true_while_moving)
15191
{
15292
int32_t pos = 50;
@@ -181,26 +121,6 @@ ZTEST_F(drv84xx_api, test_move_to_is_moving_false_when_completed)
181121
zassert_false(moving, "Driver should not be in state is_moving after finishing");
182122
}
183123

184-
ZTEST_F(drv84xx_api, test_move_by_zero_steps_no_movement)
185-
{
186-
int32_t steps = 0;
187-
188-
(void)stepper_enable(fixture->dev);
189-
(void)stepper_set_microstep_interval(fixture->dev, 20000000);
190-
(void)stepper_set_event_callback(fixture->dev, fixture->callback, NULL);
191-
(void)stepper_move_by(fixture->dev, steps);
192-
(void)k_poll(&stepper_event, 1, K_SECONDS(5));
193-
unsigned int signaled;
194-
int result;
195-
196-
k_poll_signal_check(&stepper_signal, &signaled, &result);
197-
zassert_equal(signaled, 1, "No event detected");
198-
zassert_equal(result, STEPPER_EVENT_STEPS_COMPLETED,
199-
"Event was not STEPPER_EVENT_STEPS_COMPLETED event");
200-
(void)stepper_get_actual_position(fixture->dev, &steps);
201-
zassert_equal(steps, 0, "Target position should be %d but is %d", 0, steps);
202-
}
203-
204124
ZTEST_F(drv84xx_api, test_move_by_is_moving_true_while_moving)
205125
{
206126
int32_t steps = 50;

tests/drivers/stepper/stepper_api/src/main.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,9 @@ ZTEST_F(stepper, test_get_micro_step_res)
9999
{
100100
enum stepper_micro_step_resolution res;
101101
(void)stepper_get_micro_step_res(fixture->dev, &res);
102-
zassert_equal(res, DT_PROP(DT_ALIAS(stepper), micro_step_res),
103-
"Micro step resolution not set correctly");
102+
zassert_equal(DT_PROP(DT_ALIAS(stepper), micro_step_res), res,
103+
"Micro step resolution not set correctly, expected: %d, got: %d ",
104+
DT_PROP(DT_ALIAS(stepper), micro_step_res), res);
104105
}
105106

106107
ZTEST_F(stepper, test_set_micro_step_interval_invalid_zero)

0 commit comments

Comments
 (0)