fix(mcp): business agent and catalog tools take their path ids (#54)

The MCP generator kept only PageParam among referenced parameters and dropped
the rest, so the business agent and product catalog tools had no account,
catalog, connector, tool or product id and could not be called. Both
generators now share one resolver, and the tools are regenerated.

Feedback: feedback_6ad87b06bf2c6d56c1f4fd7c

Author: Zernio-Elean

scripts/generate_mcp_tools.py

@@ -21,7 +21,7 @@
 from typing import Any
 
 import yaml
-from openapi_body import flatten_request_body_schema
+from openapi_body import flatten_request_body_schema, resolve_parameter_ref
 
 # Map OpenAPI tags to SDK resource names
 TAG_TO_RESOURCE: dict[str, str] = {
@@ -372,7 +372,8 @@ def extract_parameters(
     """Extract parameters from operation.
 
     `spec` is threaded through so `get_python_type` can dereference
-    `$ref`/`allOf` schemas to read the underlying type.
+    `$ref`/`allOf` schemas to read the underlying type. A `$ref` parameter
+    without `spec` raises ValueError.
 
     Dedupes by Python name: when the same parameter appears in both the path
     and the request body (e.g. `accountId` as a path param and also in the
@@ -390,27 +391,7 @@ def add_param(entry: dict[str, Any]) -> None:
         params.append(entry)
 
     for param in operation.get("parameters", []):
-        if "$ref" in param:
-            ref = param["$ref"]
-            if "PageParam" in ref:
-                add_param({
-                    "name": "page",
-                    "type": "int",
-                    "required": False,
-                    "default": "1",
-                    "description": "Page number",
-                    "sdk_name": "page",
-                })
-            elif "LimitParam" in ref:
-                add_param({
-                    "name": "limit",
-                    "type": "int",
-                    "required": False,
-                    "default": "10",
-                    "description": "Results per page",
-                    "sdk_name": "limit",
-                })
-            continue
+        param = resolve_parameter_ref(param, spec)
 
         if "name" not in param:
             continue

scripts/generate_resources.py

@@ -22,7 +22,7 @@
 from typing import Any
 
 import yaml
-from openapi_body import flatten_request_body_schema
+from openapi_body import flatten_request_body_schema, resolve_parameter_ref
 
 # Map OpenAPI tags to resource class names
 TAG_TO_RESOURCE: dict[str, str] = {
@@ -136,17 +136,7 @@ def extract_parameters(
 
     # Query/path parameters
     for param in operation.get("parameters", []):
-        # Resolve reusable parameters before extracting their name and location.
-        # Silently dropping a path parameter produces broken URL templates.
-        seen_refs: set[str] = set()
-        while "$ref" in param:
-            ref = param["$ref"]
-            if not ref.startswith("#/") or ref in seen_refs:
-                raise ValueError(f"Unsupported or cyclic parameter reference: {ref}")
-            seen_refs.add(ref)
-            param = spec
-            for part in ref[2:].split("/"):
-                param = param[part.replace("~1", "/").replace("~0", "~")]
+        param = resolve_parameter_ref(param, spec)
 
         if "name" not in param:
             continue

scripts/openapi_body.py

@@ -14,6 +14,23 @@ def resolve_local_ref(ref: str, spec: dict[str, Any]) -> dict[str, Any]:
     return node if isinstance(node, dict) else {}
 
 
+def resolve_parameter_ref(
+    param: dict[str, Any], spec: dict[str, Any] | None
+) -> dict[str, Any]:
+    # Resolve reusable parameters before extracting their name and location.
+    # Silently dropping a path parameter produces broken URL templates.
+    seen_refs: set[str] = set()
+    while "$ref" in param:
+        ref = param["$ref"]
+        if spec is None or not ref.startswith("#/") or ref in seen_refs:
+            raise ValueError(f"Unsupported or cyclic parameter reference: {ref}")
+        seen_refs.add(ref)
+        param = spec
+        for part in ref[2:].split("/"):
+            param = param[part.replace("~1", "/").replace("~0", "~")]
+    return param
+
+
 def flatten_request_body_schema(
     schema: dict[str, Any], spec: dict[str, Any]
 ) -> dict[str, Any] | None: