Skip to content

Commit 37d03ff

Browse files
committed
Fixed method signature of dup() method in codec
1 parent 6d1f1f2 commit 37d03ff

File tree

4 files changed

+47
-56
lines changed

4 files changed

+47
-56
lines changed

model/codec_java.gsl

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -564,30 +564,27 @@ public class $(ClassName)
564564
// --------------------------------------------------------------------------
565565
// Duplicate the $(ClassName) message
566566

567-
public $(ClassName) dup ($(ClassName) self)
567+
public $(ClassName) dup ()
568568
{
569-
if (self == null)
570-
return null;
571-
572-
$(ClassName) copy = new $(ClassName) (self.id);
573-
if (self.address != null)
574-
copy.address = self.address.duplicate ();
575-
switch (self.id) {
569+
$(ClassName) copy = new $(ClassName) (this.id);
570+
if (this.address != null)
571+
copy.address = this.address.duplicate ();
572+
switch (this.id) {
576573
.for class.message
577574
case $(MESSAGE.NAME):
578575
. for field
579576
. if type = "number"
580-
copy.$(name) = self.$(name);
577+
copy.$(name) = this.$(name);
581578
. elsif type = "octets"
582-
System.arraycopy (copy.$(name), 0, self.$(name), 0, $(size));
579+
System.arraycopy (copy.$(name), 0, this.$(name), 0, $(size));
583580
. elsif type = "string"
584-
copy.$(name) = self.$(name);
581+
copy.$(name) = this.$(name);
585582
. elsif type = "strings"
586-
copy.$(name) = new ArrayList <String> (self.$(name));
583+
copy.$(name) = new ArrayList <String> (this.$(name));
587584
. elsif type = "dictionary"
588-
copy.$(name) = new HashMap <String, String> (self.$(name));
585+
copy.$(name) = new HashMap <String, String> (this.$(name));
589586
. elsif type = "frame"
590-
copy.$(name) = self.$(name).duplicate ();
587+
copy.$(name) = this.$(name).duplicate ();
591588
. endif
592589
. endfor
593590
break;

src/main/java/org/zyre/ZreGroup.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ public void leave (ZrePeer peer)
8080
public void send (ZreMsg msg)
8181
{
8282
for (ZrePeer peer: peers.values ())
83-
peer.send (msg.dup (msg));
83+
peer.send (msg.dup ());
8484

8585
msg.destroy ();
8686
}

src/main/java/org/zyre/ZreLogMsg.java

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -368,22 +368,19 @@ public static void sendLog (
368368
// --------------------------------------------------------------------------
369369
// Duplicate the ZreLogMsg message
370370

371-
public ZreLogMsg dup (ZreLogMsg self)
371+
public ZreLogMsg dup ()
372372
{
373-
if (self == null)
374-
return null;
375-
376-
ZreLogMsg copy = new ZreLogMsg (self.id);
377-
if (self.address != null)
378-
copy.address = self.address.duplicate ();
379-
switch (self.id) {
373+
ZreLogMsg copy = new ZreLogMsg (this.id);
374+
if (this.address != null)
375+
copy.address = this.address.duplicate ();
376+
switch (this.id) {
380377
case LOG:
381-
copy.level = self.level;
382-
copy.event = self.event;
383-
copy.node = self.node;
384-
copy.peer = self.peer;
385-
copy.time = self.time;
386-
copy.data = self.data;
378+
copy.level = this.level;
379+
copy.event = this.event;
380+
copy.node = this.node;
381+
copy.peer = this.peer;
382+
copy.time = this.time;
383+
copy.data = this.data;
387384
break;
388385
}
389386
return copy;

src/main/java/org/zyre/ZreMsg.java

Lines changed: 24 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -673,47 +673,44 @@ public static void sendPing_Ok (
673673
// --------------------------------------------------------------------------
674674
// Duplicate the ZreMsg message
675675

676-
public ZreMsg dup (ZreMsg self)
676+
public ZreMsg dup ()
677677
{
678-
if (self == null)
679-
return null;
680-
681-
ZreMsg copy = new ZreMsg (self.id);
682-
if (self.address != null)
683-
copy.address = self.address.duplicate ();
684-
switch (self.id) {
678+
ZreMsg copy = new ZreMsg (this.id);
679+
if (this.address != null)
680+
copy.address = this.address.duplicate ();
681+
switch (this.id) {
685682
case HELLO:
686-
copy.sequence = self.sequence;
687-
copy.ipaddress = self.ipaddress;
688-
copy.mailbox = self.mailbox;
689-
copy.groups = new ArrayList <String> (self.groups);
690-
copy.status = self.status;
691-
copy.headers = new HashMap <String, String> (self.headers);
683+
copy.sequence = this.sequence;
684+
copy.ipaddress = this.ipaddress;
685+
copy.mailbox = this.mailbox;
686+
copy.groups = new ArrayList <String> (this.groups);
687+
copy.status = this.status;
688+
copy.headers = new HashMap <String, String> (this.headers);
692689
break;
693690
case WHISPER:
694-
copy.sequence = self.sequence;
695-
copy.content = self.content.duplicate ();
691+
copy.sequence = this.sequence;
692+
copy.content = this.content.duplicate ();
696693
break;
697694
case SHOUT:
698-
copy.sequence = self.sequence;
699-
copy.group = self.group;
700-
copy.content = self.content.duplicate ();
695+
copy.sequence = this.sequence;
696+
copy.group = this.group;
697+
copy.content = this.content.duplicate ();
701698
break;
702699
case JOIN:
703-
copy.sequence = self.sequence;
704-
copy.group = self.group;
705-
copy.status = self.status;
700+
copy.sequence = this.sequence;
701+
copy.group = this.group;
702+
copy.status = this.status;
706703
break;
707704
case LEAVE:
708-
copy.sequence = self.sequence;
709-
copy.group = self.group;
710-
copy.status = self.status;
705+
copy.sequence = this.sequence;
706+
copy.group = this.group;
707+
copy.status = this.status;
711708
break;
712709
case PING:
713-
copy.sequence = self.sequence;
710+
copy.sequence = this.sequence;
714711
break;
715712
case PING_OK:
716-
copy.sequence = self.sequence;
713+
copy.sequence = this.sequence;
717714
break;
718715
}
719716
return copy;

0 commit comments

Comments
 (0)