Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing v5 with the included prebuilds on npm #451

Closed
aminya opened this issue Apr 15, 2021 · 5 comments
Closed

Publishing v5 with the included prebuilds on npm #451

aminya opened this issue Apr 15, 2021 · 5 comments

Comments

@aminya
Copy link
Member

aminya commented Apr 15, 2021

I was finally able to fix the build issues for v5 by switching to GitHub Actions and prebuildify. I used my personal account to publish ZeroMQ for Hydrogen, but we should also release an official version.

The process for publishing described here:
https://github.com/zeromq/zeromq.js/blob/5.x/CONTRIBUTING.md#releasing-a-new-npm-version

@albertowd
Copy link

albertowd commented Apr 15, 2021

Do you think this update changed the way the lib is compiled? Since yesterday my x86 builds cannot be compiled anymore, the last useful version I can compile is 5.2.0. My x64 compilations are still working as expected.

This are my x86 compile logs:
5.2.0-ia32.log
5.2.1-ia32.log
5.2.4-ia32.log

@aminya
Copy link
Member Author

aminya commented Apr 16, 2021

@albertowd I will release a new version with the prebuilds included and then you check if the error still presits. The latest released version is kind of fauly as it doesn't include any prebuilds.

@aminya
Copy link
Member Author

aminya commented Apr 16, 2021

OK, this is fixed now. 5.2.6 was released with the included prebuilds

@aminya aminya closed this as completed Apr 16, 2021
@albertowd
Copy link

Ok, but now I'm having another problem: the prebuilds are working on a node environment, but not after I've created an .exe and copy the correct prebuild.node to the folder:

Error: No native build was found for platform=win32 arch=ia32 runtime=node abi=72 uv=1 libc=glibc node=12.18.1
loaded from: C:\snapshot\channel-agent\node_modules\zeromq

@aminya
Copy link
Member Author

aminya commented Apr 16, 2021

Node-gyp-build relies on the location of the prebuilds folder. You shouldn't move those. Also, in case you use a bundler, declare ZeroMQ as external so it is not bundled because of this issue.

If you plan to move things, make sure that the entry code always has the prebuilds folder beside it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants