Add tests

Author: puddly

tests/test_application.py

@@ -22,6 +22,7 @@
     FlowControlType,
     GetChipInfoRsp,
     GetRouteTableEntryRsp,
+    GetTxPowerInfoRsp,
 )
 import bellows.types
 import bellows.types as t
@@ -2639,3 +2640,46 @@ async def test_migration_failure_eui64_overwrite_confirmation(
         assert app._ezsp.write_custom_eui64.mock_calls == [
             call(t.EUI64.convert("aa:aa:aa:aa:aa:aa:aa:aa"), burn_into_userdata=True)
         ]
+
+
+async def test_tx_power_with_xncp_feature(app: ControllerApplication) -> None:
+    """Test TX power methods with XNCP TX_POWER_INFO feature."""
+    app._ezsp._xncp_features |= FirmwareFeatures.TX_POWER_INFO
+    app._ezsp.xncp_get_tx_power_info = AsyncMock(
+        return_value=GetTxPowerInfoRsp(recommended_power_dbm=10, max_power_dbm=20)
+    )
+
+    assert await app.get_recommended_tx_power("US") == 10.0
+    assert await app.get_maximum_tx_power("US") == 20.0
+
+
+async def test_tx_power_without_xncp_feature(app: ControllerApplication) -> None:
+    """Test TX power methods fall back to parent class without XNCP feature."""
+    app._ezsp._xncp_features = FirmwareFeatures.NONE
+    app._ezsp.xncp_get_tx_power_info = AsyncMock()
+
+    app_cls = zigpy.application.ControllerApplication
+
+    ezsp_rec_tx_power = await app.get_recommended_tx_power("US")
+    base_rec_tx_power = await app_cls.get_recommended_tx_power(app, "US")
+    assert ezsp_rec_tx_power == base_rec_tx_power
+
+    ezsp_max_tx_power = await app.get_maximum_tx_power("US")
+    base_max_tx_power = await app_cls.get_maximum_tx_power(app, "US")
+    assert ezsp_max_tx_power == base_max_tx_power
+
+    assert len(app._ezsp.xncp_get_tx_power_info.mock_calls) == 0
+
+
+async def test_set_tx_power(app: ControllerApplication) -> None:
+    """Test set_tx_power with float-to-int conversion and NVRAM persistence."""
+    app._ezsp.setRadioPower = AsyncMock()
+
+    with patch(
+        "bellows.zigbee.repairs.update_tx_power", return_value=True
+    ) as mock_update:
+        result = await app.set_tx_power(12.7)
+
+    assert result == 12.0
+    assert app._ezsp.setRadioPower.mock_calls == [call(power=12)]
+    assert mock_update.mock_calls == [call(app._ezsp, tx_power=12)]

tests/test_xncp.py

@@ -291,3 +291,26 @@ async def test_xncp_route_table_operations(ezsp_f: EZSP) -> None:
             ).serialize()
         )
     ]
+
+
+async def test_xncp_get_tx_power_info(ezsp_f: EZSP) -> None:
+    """Test XNCP get_tx_power_info."""
+    ezsp_f._mock_commands["customFrame"] = customFrame = AsyncMock(
+        return_value=[
+            t.EmberStatus.SUCCESS,
+            xncp.XncpCommand.from_payload(
+                xncp.GetTxPowerInfoRsp(recommended_power_dbm=10, max_power_dbm=20)
+            ).serialize(),
+        ]
+    )
+
+    rsp = await ezsp_f.xncp_get_tx_power_info("us")
+    assert rsp.recommended_power_dbm == 10
+    assert rsp.max_power_dbm == 20
+    assert customFrame.mock_calls == [
+        call(
+            xncp.XncpCommand.from_payload(
+                xncp.GetTxPowerInfoReq(country_code=b"US")
+            ).serialize()
+        )
+    ]

tests/test_zigbee_repairs.py

@@ -174,3 +174,69 @@ async def test_fix_invalid_tclk_all_versions(
         ]
     else:
         assert "NV3 interface not available in this firmware" in caplog.text
+
+
+async def test_update_tx_power(ezsp_f: EZSP, caplog) -> None:
+    """Test update_tx_power behavior in various scenarios."""
+    token_data = t.NV3StackNodeData(
+        panId=t.EmberPanId(0x1234),
+        radioTxPower=t.int8s(5),
+        radioFreqChannel=t.uint8_t(15),
+        stackProfile=t.uint8_t(0x02),
+        nodeType=t.EmberNodeType.COORDINATOR,
+        zigbeeNodeId=t.EmberNodeId(0x0000),
+        extendedPanId=t.ExtendedPanId.convert("AA:BB:CC:DD:EE:FF:00:11"),
+    )
+
+    # Test 1: NV3 interface unavailable
+    ezsp_f.getTokenData = AsyncMock(side_effect=InvalidCommandError())
+    with caplog.at_level(logging.WARNING):
+        assert await repairs.update_tx_power(ezsp_f, tx_power=10) is False
+    assert "NV3 interface not available in this firmware" in caplog.text
+
+    # Test 2: TX power already correct (no write needed)
+    ezsp_f.getTokenData = AsyncMock(
+        return_value=GetTokenDataRsp(
+            status=t.EmberStatus.SUCCESS,
+            value=token_data.replace(radioTxPower=t.int8s(10)).serialize(),
+        )
+    )
+    ezsp_f.setTokenData = AsyncMock()
+    ezsp_f.getNetworkParameters = AsyncMock()
+    assert await repairs.update_tx_power(ezsp_f, tx_power=10) is False
+    assert len(ezsp_f.setTokenData.mock_calls) == 0
+    assert len(ezsp_f.getNetworkParameters.mock_calls) == 0
+
+    # Test 3: Successful TX power update
+    ezsp_f.getTokenData = AsyncMock(
+        return_value=GetTokenDataRsp(
+            status=t.EmberStatus.SUCCESS,
+            value=token_data.serialize(),
+        )
+    )
+    ezsp_f.getNetworkParameters = AsyncMock(
+        return_value=[
+            t.EmberStatus.SUCCESS,
+            t.EmberNodeType.COORDINATOR,
+            t.EmberNetworkParameters(
+                panId=t.EmberPanId(0x1234),
+                extendedPanId=t.ExtendedPanId.convert("AA:BB:CC:DD:EE:FF:00:11"),
+                radioChannel=t.uint8_t(15),
+                radioTxPower=t.int8s(5),
+                joinMethod=t.EmberJoinMethod.USE_MAC_ASSOCIATION,
+                nwkManagerId=t.EmberNodeId(0x0000),
+                nwkUpdateId=t.uint8_t(0),
+                channels=t.Channels.ALL_CHANNELS,
+            ),
+        ]
+    )
+    ezsp_f.setTokenData = AsyncMock(return_value=[t.EmberStatus.SUCCESS])
+
+    assert await repairs.update_tx_power(ezsp_f, tx_power=15) is True
+    assert ezsp_f.setTokenData.mock_calls == [
+        call(
+            token=t.NV3KeyId.NVM3KEY_STACK_NODE_DATA,
+            index=0,
+            token_data=token_data.replace(radioTxPower=t.int8s(15)).serialize(),
+        )
+    ]