Skip to content

5.X doesn't support finalizing L2AssetRouter withdrawals #267

@nicholaspai

Description

@nicholaspai

🌟 Feature Request

📝 Description

For projects still using ethers 5.X, upgrading to 6.X is not an easy task, so we are currently stuck at 5.11.0 of the zkync-ethers version. Unfortunately, this version doesn't seem to support finalizing.

🤔 Rationale

This will allow projects using ethers 5.X, which will be many older projects that have been around for a while, to keep using the zksync-ethers package.

🖼️ Mockups/Examples

this code no longer works because l1SharedBridge() isn't a function on the L2AssetRouter and the 5.11 SDK doesn't call the L1Nullifier to finalizeDeposit(), instead it calls the L1SharedBridge's finalizeWithdrawal() method.

📋 Additional Context

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions