Hide previous marks persists to next subject, but will show 2nd mark

[seanmiller26]

Package

Choose from the list:

• app-content-pages
• [ X ] app-project
• lib-classifier
• lib-panoptes-js
• lib-react-components
• unknown

Describe the bug

When you are classifying on a drawing task you can select "Hide previous marks." After submitting a classification, the marks do not show on the next subject. However, you can still draw new marks. The 1st mark will be hidden, and subsequent marks will show. If you then press "show previous marks" you will see the 1st hidden mark has actually been recorded. See this video for more details.

Owl-Detector-Dataset-2024-03-Wildwatch-Burrowing-Owl-Zooniverse---People-powered-research.mp4

To Reproduce

Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Screenshots

If applicable, add screenshots to help explain your problem.

Expected behavior

A clear and concise description of what you expected to happen.

Device information

Desktop (please complete the following information):

• OS: [e.g. Windows 10]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone]
• OS:
• Browser:
• Versio:

Additional context

Add any other context about the problem here.

[eatyourgreens]

The bug here is in task.hidingIndex, which is persisted across subjects. So, if you hide two marks, say, then the first two marks will always be hidden for each new subject.

The transcription task shares code with the drawing task, so this bug also affects transcription projects.

My fix in #6098 is to explicitly reset the Show Previous Marks toggle when the subject changes, except when the toggle state is SHOWN_MARKS.USER.

[eatyourgreens]

This bug was introduced in #1610 (April 2020), so it definitely affects transcription projects.

[eatyourgreens]

Here's a screen recording of the same bug on a transcription project. I hide 3 marks on the first subject, so my clicks appear to be ignored for the first 3 lines of the next new subject. I have created three new empty lines, but they are hidden and I can't add text to them.

I don't know if it's common for people to use the 'Hide all marks' option on transcription projects, like they do on WildWatch Burrowing Owl.

Screen.Recording.2024-05-19.at.09.33.48.mov

[eatyourgreens]

There's also a subtle bug in both the drawing task and the transcription task, where drawing, editing or deleting a mark won't automatically update the current classification unless you remember to manually call annotation.update(marks), in the code, with the new marks array. I opened #5923 a while ago, to fix that particular bug. That bug also caused marks to apparently disappear (because they weren't listed in the active classification after being modified.)

At the moment, the workaround in the classifier is to manually call annotation.update(marks) (#5919), but that might not necessarily catch every case where the classification should change.