Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survey task: increase task area width to 540px for workflow with survey task #6237

Open
1 of 6 tasks
seanmiller26 opened this issue Aug 27, 2024 · 6 comments · May be fixed by #6297
Open
1 of 6 tasks

Survey task: increase task area width to 540px for workflow with survey task #6237

seanmiller26 opened this issue Aug 27, 2024 · 6 comments · May be fixed by #6297
Assignees
Labels
design Design and/or UX enhancement New feature or request

Comments

@seanmiller26
Copy link
Contributor

seanmiller26 commented Aug 27, 2024

Package

Choose from the list:

  • app-content-pages
  • app-project
  • lib-classifier
  • lib-panoptes-js
  • lib-react-components
  • unknown

Is your feature request related to a problem? Please describe.

Allow more space for the task area and its components. In turn, this helps with #6210 when the task is a Survey.

Describe the solution you'd like

Increase the task area to be 540px. Figme for reference https://www.figma.com/design/ASqNlLhicNRzEDhYDA2t8j/Survey?node-id=65-1006&m=dev&t=PxDxXDB67AH8V9Aa-1
Specific margins and other annotations here:

Screenshot 2024-08-28 at 1 59 58 PM

Additional context

Add any other context or screenshots about the feature request here.

@seanmiller26 seanmiller26 added enhancement New feature or request design Design and/or UX labels Aug 27, 2024
@mcbouslog mcbouslog self-assigned this Sep 5, 2024
@mcbouslog mcbouslog changed the title Survey task: increase width to 540px Survey task: increase task area width to 540px for step with survey task Sep 6, 2024
@mcbouslog
Copy link
Contributor

@seanmiller26 - for a workflow with multiple steps, should the increased task area width apply to steps without a survey task or only to a step with a survey task?

@seanmiller26
Copy link
Contributor Author

Yes, we should keep the task area a consistent size, if possible.

@mcbouslog mcbouslog changed the title Survey task: increase task area width to 540px for step with survey task Survey task: increase task area width to 540px for workflow with survey task Sep 6, 2024
@mcbouslog
Copy link
Contributor

@seanmiller26 - currently the subject viewer and task area layout goes from horizontal to vertical at 768px (small breakpoint). Should the subject viewer and task area change from horizontal to vertical at a different breakpoint with these changes?

The Grommet ResponsiveContext medium breakpoint discussion could be applicable to this issue.

@seanmiller26
Copy link
Contributor Author

Yes, this is something I'd like to explore with this task as a pathfinder for other task types. I think best to move forward with the initial styling in this issue. Then I can try it out on staging and I'll be able to make a more informed decision once I can play around with it.

@goplayoutside3
Copy link
Contributor

@mcbouslog there was recent discussion about unexpected changes to task area styling when going back and forth between task types in this Issue: #6271 (comment)

Not caused by any changes to the survey task code, but I want to link it here in case it's worth considering better management of task area styling in general.

@eatyourgreens
Copy link
Contributor

Hi, I’ve moved that conversation from #6271 to #6275. It’s a bug in the single image viewer styling, when ‘limit subject height’ is enabled. The viewer is styled with max-height, so the browser is free to render it at any height smaller than that value.

@mcbouslog mcbouslog linked a pull request Sep 12, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design and/or UX enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants