Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read attribute to notification resource #160

Open
mcbouslog opened this issue Oct 17, 2018 · 1 comment
Open

Add read attribute to notification resource #160

mcbouslog opened this issue Oct 17, 2018 · 1 comment

Comments

@mcbouslog
Copy link

A read attribute on the notification resource would be helpful, with a boolean to denote read or unread status.

PFE is currently using the delivered attribute on the notification resource for the header notifications count and UI on the notifications page for read or unread status of notifications. This can be confusing when the Talk API (properly, as intended) toggles delivered from false to true when a user is emailed according to their notification email settings.

Please see this comment from related PFE Issue 4727 for additional information.

Notable code:

@eatyourgreens
Copy link

I came across this again this morning. I asked a question on Every Name Counts yesterday. Two volunteers replied overnight but their replies were marked as already read when I checked my notifications on the site today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants