Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn PWESuite into a package #12

Open
zouharvi opened this issue Feb 18, 2025 · 1 comment
Open

Turn PWESuite into a package #12

zouharvi opened this issue Feb 18, 2025 · 1 comment

Comments

@zouharvi
Copy link
Owner

zouharvi commented Feb 18, 2025

This is a larger issue but the outcome should be:

  • more reproducible refactor of pwesuite
  • making pwesuite into a package that can easily run phonetic word embedding models
  • moving top-level directories to pwesuite such that pip install -e does not pollute the global namespace
  • other quality of life
zouharvi added a commit that referenced this issue Feb 18, 2025
JeffBezos64 added a commit to JeffBezos64/pwesuite that referenced this issue Feb 18, 2025
@JeffBezos64
Copy link
Contributor

As part of the repackaging you/we should look to include optional [dev] dependency declarations in pyproject.toml

zouharvi pushed a commit that referenced this issue Feb 19, 2025
* This change is to reflect the current python version requirement of panphon2 which is only released up to Python 3.11

* This commit adds a (untested) lower bound on the python version compliant with PEP440

* updated .gitignore to ignore a dev_venv virtual environment to make keeping the repo tidier easier

* Added an if clause around the MACOS platform dependent command in the script

* tidied up comment

* updated script to use 2.0.0 release which is available from the cmuflite website

* updated the script to pull from flite github and pull from source there

* added test of environmental variable and setup script to detect if it is set

* tested non-root build of dataset script, still the outstanding issue but lex_lookup and flite now build

* updated Readme with information relating to the updates/changes I have made as well as more of an install guide for Dev

* added information on python path

* cleared up README.md

* resolving comment RE issue #12 Python packaging rather than a workaround

* fixed typos and reduced size of notes

* fixed further typo

* updated all.sh to remove workaround related code but preserve the MacOS detection

* added pyproject.toml

* removed setup.py

* added more to pyproject.toml so it actually builds somewhat properly

* added missing packages

---------

Merged by: Vilém Zouhar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants