Feature/player meesanger #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/zpapoo/ncha-frontend/2meqm5eh4 |
- player top position
JaeYeopHan
approved these changes
Dec 9, 2019
| @@ -7,7 +7,7 @@ | |||
| "dev": "next dev", | |||
| "build": "next build", | |||
| "start": "next start", | |||
| "lint": "eslint ." | |||
| "lint": "eslint ./ --ext ts,tsx" | |||
There was a problem hiding this comment.
nit) lint는 냅두고 lint:fix script 추가는 어때요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desc
Figma 시안 중
player_messanger부분의 마크업을 진행했습니다. #8swipe동작이나 스포일러 봇 해제 등의 interaction이 들어가는 부분은 구현되어 있지 않습니다.
그외 변경사항
HowToRun?
http://localhost:3000/player/1