Ensure reserved names in params or query don't break ReScript #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The codegen tool did not yet account for reserved keywords when generating code. This caused a query parameter such as `type` to generate code that would refuse to compile. To fix this a list of reserved keywords are added that get an underscore added as suffix. Fixes #30
|
Great! Would it be possible to somehow add either a test, or something to the example app that shows this works both for query params and path params? Coming to think of it, maybe we should have 2 "example" apps? One actual example, and one fixture-style that's just around to show that the codegen works and compiles. That'll make it easy for us to cram "regression fixtures" into there without it being awkward. |
|
Yeah I was thinking about that but wasn't sure where to put it. I'll see what I can do :) |
We want to test some cases for which traditional testing tools are not entirely suitable. For example testing that a `routes.json` file turns into compilable ReScript code. For this we create workspaces in `tests/*` that allow us to test specific cases. The initial added case demonstrates an issue with using reserved words in parameter names or query parameter names.
|
Great addition with the regression test suite! I'll look into this sometime next week, it doesn't feel pressing for the alpha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codegen tool did not yet account for reserved keywords when
generating code. This caused a query parameter such as
typetogenerate code that would refuse to compile.
To fix this a list of reserved keywords are added that get an underscore
added as suffix.
Fixes #30