DT-68: Implement frontend data loading for deployment tables#69
Merged
abdotop merged 4 commits into66-implementation-of-table-data-fetching-and-filteringfrom Oct 21, 2025
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements frontend data loading for deployment tables by integrating backend API calls for schema and table data retrieval. The changes enable dynamic loading of database schemas and table contents with filtering, sorting, and search capabilities.
Key Changes:
- Added API signal integration for fetching deployment schema and table data
- Implemented reactive effects to trigger data fetches based on URL parameter changes
- Enhanced UI components with improved styling, accessibility, and user feedback
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| web/pages/DeploymentPage.tsx | Core implementation of schema/table data loading with API signals, filter/sort parsing, and UI enhancements for tables and left panel |
| web/components/Filtre.tsx | Exported parseFilters and parseSort functions for external use |
| api/routes.ts | Changed table data endpoint from GET to POST method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| <button | ||
| type='button' | ||
| class='btn btn-ghost btn-xs' | ||
| disabled={schema.pending !== undefined} |
There was a problem hiding this comment.
The disabled condition schema.pending !== undefined is incorrect. A signal's pending property is typically a boolean, so this should be disabled={schema.pending} or disabled={!!schema.pending}.
Suggested change
| disabled={schema.pending !== undefined} | |
| disabled={!!schema.pending} |
| effect(() => { | ||
| const { dep, tab, table, tq } = url.params | ||
| if (dep && tab === 'tables') { | ||
| const tableName = table || schema.data?.tables?.[0]?.table |
There was a problem hiding this comment.
The fallback to the first table may cause unintended behavior if schema.data.tables changes while a different table is selected. This could trigger unnecessary fetches. Consider checking if tableName exists before proceeding with the fetch.
Suggested change
| const tableName = table || schema.data?.tables?.[0]?.table | |
| const tables = schema.data?.tables || [] | |
| let tableName: string | undefined | |
| if (table) { | |
| // Only use the table if it exists in the schema | |
| tableName = tables.find((t) => t.table === table)?.table | |
| } | |
| if (!tableName && tables.length > 0) { | |
| tableName = tables[0].table | |
| } |
abdotop
force-pushed
the
68-implement-frontend-data-loading-for-deployment-tables
branch
from
3489c62 to
93e0e2b
Compare
abdotop
force-pushed
the
66-implementation-of-table-data-fetching-and-filtering
branch
from
51805fb to
3b86820
Compare
abdotop
force-pushed
the
68-implement-frontend-data-loading-for-deployment-tables
branch
from
93e0e2b to
8da793c
Compare
abdotop
force-pushed
the
66-implementation-of-table-data-fetching-and-filtering
branch
from
3b86820 to
1dc16e2
Compare
abdotop
force-pushed
the
68-implement-frontend-data-loading-for-deployment-tables
branch
2 times, most recently
from
63f91e0 to
e8ca19c
Compare
…ata retrieval feat(Filtre): export parseFilters and parseSort functions for external use feat(DeploymentPage): integrate filter and sort functionality for deployment table data
abdotop
force-pushed
the
68-implement-frontend-data-loading-for-deployment-tables
branch
from
ee8515e to
b958ae2
Compare
abdotop
merged commit 3bfe3c3
into
66-implementation-of-table-data-fetching-and-filtering
2 checks passed
abdotop
deleted the
68-implement-frontend-data-loading-for-deployment-tables
branch
abdotop
added a commit
that referenced
this pull request
Oct 21, 2025
* feat(routes): add new endpoint for retrieving deployment table data * docs(routes): add comment for deployments in route definitions * feat(routes): add new endpoint for retrieving deployment table data * docs(routes): add comment for deployments in route definitions * feat(routes): add POST endpoint for fetching deployment table data with filtering and sorting * feat(schema, sql): add columnsMap to DatabaseSchemaDef and update fetchTablesData to use it * DT-68: Implement frontend data loading for deployment tables (#69) * feat(routes): change endpoint from GET to POST for deployment table data retrieval feat(Filtre): export parseFilters and parseSort functions for external use feat(DeploymentPage): integrate filter and sort functionality for deployment table data * feat(DeploymentPage): refactor data fetching and improve table display logic * feat(DeploymentPage): refactor layout and improve component structure * fix(DeploymentPage): correct parameter name from tq to qt for search functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.