Bug: Auto-refresh does not trigger in query views#89
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the columnsMap data structure from a Map<string, ColumnInfo> to a plain JavaScript object (Record<string, ColumnInfo>), and includes several UI layout fixes to address overflow issues.
Changes:
- Refactored
columnsMapfrom Map to plain object in schema refresh logic - Added overflow and sizing fixes to UI components for better layout control
- Reconstructed Map from plain object when needed for table data fetching
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| api/sql.ts | Changed columnsMap construction to use plain object instead of Map |
| api/routes.ts | Added logic to reconstruct Map from plain object when calling fetchTablesData |
| web/pages/DeploymentPage.tsx | Changed table width class from w-full to min-w-full |
| web/components/SideBar.tsx | Added overflow-hidden class to drawer-side container |
| web/components/BackgroundPattern.tsx | Added explicit sizing constraints to fixed background container |
Comments suppressed due to low confidence (2)
api/sql.ts:92
- The
TableInfotype definition still declarescolumnsMapasMap<string, ColumnInfo>, but the implementation now stores it asRecord<string, ColumnInfo>. Update the type definition to match:columnsMap: Record<string, ColumnInfo>
columnsMap: Map<string, ColumnInfo>
api/sql.ts:110
- The initialization still uses
new Map()but should be changed to{}to match the new plain object implementation.
tableMap.set(key, { schema, table, columns: [], columnsMap: new Map() })
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…e, alongside various UI layout and overflow fixes.
4df3432 to
122cabc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: Refactor
columnsMapto a plain object and adjust its usage, alongside various UI layout and overflow fixes.