[EXTERNAL] Removes some duplicate files#3113
Open
motonai wants to merge 1 commit into01-edu:masterfrom
Open
Conversation
e532312 to
878172b
Compare
878172b to
0a83d42
Compare
0a83d42 to
ee3459e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[EXTERNAL]
I noticed in
groupie-tracker(but also in other subjects) that there are duplicate files inside the project's directories. Apparently, there is this pattern:The only think changing between them is the link to the
good-practicesdocument.Why?
They seem to serve no purpose. As far as other projects' structures suggest, the
README.mdfile under theauditdirectory of asubprojectis the one that is valid.Solution Overview
Removal of the duplicates for the
groupie-tracker's subprojects.Implementation Details
In the cases included in the PR, I choose to remove only the ones for
groupie-trackerproject.I choose to not remove other duplicates, since there are some cases that the differences exceed the link to the
good-practicesdocument. For example, in the subproject0-shell/job-control, one suggests to runlswhile the other suggeststar. While the convention seem to be straight-forward, for those that differ more than the link, I wanted to check with you first and I can append the current PR or revisit on a new one.I found those with the following: