Fix incorrect assoc usage on string list in majutsu-base.el

[Copilot]

Addresses review feedback on PR #24: majutsu-buffer-diff-range is a list of strings like ("--revisions=@-") or ("--from=@-" "--to=@"), not an alist. Using assoc on it always returns nil.

Changes

• Replace (cdr (assoc "--revisions=" range)) with seq-find + string-prefix-p pattern
• Align with existing majutsu-file--diff-range-value implementation (lines 107-111)

Before:

(cdr (assoc "--revisions=" range))

After:

(when-let* ((arg (seq-find (lambda (item) (string-prefix-p "--revisions=" item)) range)))
  (substring arg (length "--revisions=")))

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Summary by CodeRabbit

• Bug Fixes
  • Improved revision value extraction to handle more diverse input formats reliably.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details

{"name":"HttpError","status":404,"request":{"method":"PATCH","url":"https://api.github.com/repos/0WD0/majutsu/issues/comments/3830663870","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/0.0.0-development octokit-core.js/7.0.6 Node.js/24","authorization":"token [REDACTED]","content-type":"application/json; charset=utf-8"},"body":{"body":"<!-- This is an auto-generated comment: summarize by coderabbit.ai -->\n<!-- This is an auto-generated comment: failure by coderabbit.ai -->\n\n> [!CAUTION]\n> ## Review failed\n> \n> The pull request is closed.\n\n<!-- end of auto-generated comment: failure by coderabbit.ai -->\n\n<!-- walkthrough_start -->\n\n## Walkthrough\n\nModified the revision value extraction logic in `majutsu-revision-at-point` to use `seq-find` and parse the \"--revisions=\" string suffix directly, replacing the previous alist-based approach with `assoc` and conditional `-r` handling.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Revision Extraction Logic** <br> `majutsu-base.el`|Updated `majutsu-revision-at-point` to extract revision values by searching for items prefixed with \"--revisions=\" using `seq-find` and substring parsing, replacing assoc-based alist handling.|\n\n## Estimated code review effort\n\n🎯 2 (Simple) | ⏱️ ~8 minutes\n\n## Poem\n\n> A rabbit hops through revision trails,\n> Where parsing now with `seq-find` sails,\n> No more assoc in disarray,\n> String suffixes light the way! 🐰✨\n\n<!-- walkthrough_end -->\n\n\n<!-- tips_start -->\n\n---\n\n\n\n<sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub>\n\n<!-- tips_end -->\n\n<!-- internal state start -->\n\n\n<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKPR1AGxJcAYvAAeKBhMFBSiuOiIiPgMkNiIaKT8WIi4FPAYRJAeSBEZkMxoQngOYAJoiCQaJB6QkAYAco4ClFwATACckIAoBJAAqjYAMlywuLjciBwA9FNE6rDYAhpMzFMADADqACJrU4XFuA5T3NgeHlOddQZ9lRRcAML43PAe+BG9AMr42BQMJJACKjBWBcJjPV64KYOARgXhgNoAFh6MGcpAigMwDBBBSKJWwYAAZi9/p9cNR4lwnmRkTYSBJ4CQAO6USaQTY7AA0kEe4LeyPuYWodHQnEgbTWbQAbGAJTKAIzQNYADg4AFYAMwcBGqgBaRi20gY6W44nwGA4BigAEFaLQwlFpJAwvSmZACSQ6OUGABrZLWOxmRFcAAG+zxZWwBPdFDAtHgUbAQNIwZQyDQ2Vy/AJ9jSGSIyAAFFUiBoucGCwAiCDOpDwM2IAC8AAEwBWAJQp/B8ctVwkUFjN1uQXsEZvt4NtrkYPmYdA5VIAbjiiDzkGDFWiDBTiW0GFSKAiaA8jLQsmQYVwPz3kAwLw0lsgtO4HjQf2Q5YYdsgBY3MWH1bpWt6wbCsnUwUg2w7SBGXmdA10qABHQkMloFMAGp4NzTJYTCIl/FhFNuGoGgKCwAhshiIVIFwWB/mDAD6RXYDtwoIhHHYIJqNonN0kyDN90wegSH8NJXzyQ5IAkI9sCqB8rRyIhr3gZhnxINgMDJU0sBgmjIGE3JV1DXFDnxIkvAgOMEyTEgwCkjwZJTAscnIZA5TWAB2QBkAjlHy23vAxHiURhYHA/5hLQFSvAtKAACESAJLtvAMOoC0/PgfyiP9exrJi9xAsDMhISC5IJEiLRSxlaIwMAvFwAAqb8f1Y79EOQjB6CciKBFodMC3UNS2xarCiBw+KAlhf9E0A3LG1A/rmEggqIOKuoUuhVJeKyVFvy8TJdOy6a6zy9tioMCxuRYZh1AKaQElIZAHCcFwjCgaBGXwBRWHUVlZwydR4CPHgXywFYrsPdq4Lwz6wa46gnRIZ9X0dddMq3aDYODVqiXalNyOE0SxC4uiGKAvKUzsmS3X7Zg4PnCJ8GzDa80QDQLrANA8FgRLaDKeR2TWfz9GMcAoDIegGZwAhiDIZQaHoUH2C4Xh+GEcJJEdOQFCUKhVHULQdCFkxXoQZBUFnDmpdIcgqDl6HFbAxl7EcQoXABeQmG1lQ1E0bRdDAQxhdMAwwxMsoKiqGoLQraOzssK0AElpetoV6Eel35AlrFQsQIx7hCwr6BosKRKoMQjoouZYgSvgi/hxijuQCn/nyEPShyo72dwWF8AyTgHwAeQ8WguHjImlv+VJnAknTYH/CgKy5C8rzH8gRL0rx1NwJc3loigYMqeHL1Ise0qzMeiPgPhfwYAHbZnyb2+A0D6XTa/7ygBomS4SpnCxMfrLdF2dAWB5oAhIHMDAt4+L3wOvXJ+y5VxYxQlyQSh9l613WsNdApVKBj1gaTWaPBcIBFZvHbM04IgJWwO1ReJAj7XlvB4e8cBUBZ0KsgWuREKArj4uRfOtAvB11JpJaSjpUjc0iHBJmfEHBRgCGBIuNd87ww8LIVcZo5yZjSlMa+PFsBiB+CQLkyleD4HpHxfsAh4i4Bchwj6ADq6FEOP5cwccPAkWoA3aiH1a5KAYC+G2XiJbCW4F2W2QCTgCByLEdg/1pAvUgA0M0JBXGQAALKYHjNICIfhBFWgwEeWQAAvSgRhBgZEdGw0gw9IBoTaFMMAcojAAFFUjKRTlrf4NZXTxWrqKNJdB4COAMNHCsL1/aB1FhDCWFtCBW1lsKBWGkuBUEdmnZw8hNYe2ULrH2Bt/ZAA=== -->\n\n<!-- internal state end -->"},"request":{"retryCount":1}},"response":{"url":"https://api.github.com/repos/0WD0/majutsu/issues/comments/3830663870","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Sun, 01 Feb 2026 08:58:45 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-accepted-github-permissions":"issues=write; pull_requests=write","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-api-version-selected":"2022-11-28","x-github-media-type":"github.v3; format=json","x-github-request-id":"B026:323144:39BF506:FAB706C:697F15C5","x-ratelimit-limit":"6400","x-ratelimit-remaining":"6110","x-ratelimit-reset":"1769936580","x-ratelimit-resource":"core","x-ratelimit-used":"290","x-xss-protection":"0"},"data":{"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#update-an-issue-comment","status":"404"}}}

[coderabbitai]

Oops, something went wrong! Please try again later. 🐰 💔

[Copilot]

Pull request overview

This PR fixes a bug in majutsu-revision-at-point where assoc was incorrectly used on a list of strings, causing it to always return nil.

Changes:

• Replace incorrect assoc usage with seq-find + string-prefix-p pattern to properly extract the revision value from majutsu-buffer-diff-range

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.