chore: audit quick-fixes — brand, deps, gitignore#122
Conversation
- Fix stale "PwnKit" → "pwnkit" brand reference in benchmarks.py - Add pytest-timeout to dev dependencies (CI already uses --timeout=60) - Gitignore MI300X measured-results placeholder (issue #116) - Skipped adding ruff to CI: 226 lint errors found, over threshold none
|
Warning Review limit reached
Your plan includes 1 review of capacity. Refill in 29 minutes and 36 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Resolve conflicts from PR #122 quick fixes merging into main: - docs/research/kernel-aware-nas.md: combine PR's artifact pack docs with main's generated search description - scripts/nas_experiment.py: keep both PR's quality constraints/calibration and main's generated_candidate_configs() - tests/test_arch_cost_model.py: keep both constraint assertions and generated search assertions none
1 participant
Summary
src/research_engine/benchmarks.pyline 82 used capitalized "PwnKit" (old brand) — updated to lowercase "pwnkit" (the hacking-engine project name), consistent with the rest of the codebase includingdocs/system/BENCHMARKS.md.pytest-timeoutand passes--timeout=60, but it was missing frompyproject.toml. Localpytestruns now work out of the box withpip install -e '.[dev]'.docs/results/cross-vendor-measured-mi300x.jsonis an untracked zeroed-out template (issue [Cross-vendor] Replace MI300X measured template with real AMD artifact #116). Added to.gitignoreso it stops appearing ingit status.Test plan
pytest tests/ -x -q --timeout=60— 913 passed, 24 skippednone