Skip to content

Add kernel-aware NAS knob summaries#126

Open
Darkroom4364 wants to merge 1 commit into
mainfrom
issue-81-kernel-aware-nas-knobs
Open

Add kernel-aware NAS knob summaries#126
Darkroom4364 wants to merge 1 commit into
mainfrom
issue-81-kernel-aware-nas-knobs

Conversation

@Darkroom4364

Copy link
Copy Markdown
Collaborator

Closes #81.

Summary:

  • vary the generated NAS catalog across the QK-norm/RoPE branch instead of hard-coding QK-norm on
  • add machine-readable knob summaries for constrained and all candidates
  • refresh the multi-hardware NAS artifact and docs with the constrained knob winners

Verification:

  • python3 -m unittest tests.test_arch_cost_model
  • python3 -m compileall scripts/nas_experiment.py tests/test_arch_cost_model.py src/research_engine/arch_cost_model.py
  • python3 scripts/check_public_claim_artifacts.py

Note: python3 -m unittest discover is blocked locally by missing optional dependencies: numpy, pytest, and sklearn.

@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Darkroom4364, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 11 minutes and 59 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7decf578-0cd2-4abb-8d7a-35c4462822f1

📥 Commits

Reviewing files that changed from the base of the PR and between d4222c2 and b47d7d0.

📒 Files selected for processing (6)
  • docs/research/kernel-aware-nas.md
  • docs/results/README.md
  • docs/results/kernel-aware-nas-multihardware.json
  • docs/results/kernel-aware-nas-multihardware.md
  • scripts/nas_experiment.py
  • tests/test_arch_cost_model.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-81-kernel-aware-nas-knobs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kernel-aware architecture search: use kernel perf data to design models

1 participant